This is an archive of the discontinued LLVM Phabricator instance.

Differential D35855

Remove STL/microsoft-specific CFI blacklist entries
ClosedPublic

Authored by vlad.tsyrklevich on Jul 25 2017, 2:00 PM.

Details

Reviewers
pcc
llvm-commits
Commits
rG36df72b50ad8: Remove STL/microsoft-specific CFI blacklist entries
rCRT309617: Remove STL/microsoft-specific CFI blacklist entries
rL309617: Remove STL/microsoft-specific CFI blacklist entries
Summary

These functions/attributes are now explicitly handled by assigning them public LTO visibility (if appropriate) in CodeGenModule::HasHiddenLTOVisibility.

Diff Detail

Event Timeline

vlad.tsyrklevich created this revision.Jul 25 2017, 2:00 PM
Herald added a subscriber: mehdi_amini. · View Herald TranscriptJul 25 2017, 2:00 PM
pcc accepted this revision.Jul 25 2017, 2:05 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 25 2017, 2:05 PM
Closed by commit rL309617: Remove STL/microsoft-specific CFI blacklist entries (authored by pcc). · Explain WhyJul 31 2017, 1:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
cfi/
9 lines

Diff 108152

lib/cfi/cfi_blacklist.txt

# Standard library types.
type:std::*
# The stdext namespace contains Microsoft standard library extensions.
type:stdext::*
# Types with a uuid attribute, i.e. COM types.
type:attr:uuid
# STL allocators (T *allocator<T *>::allocate(size_type, const void*)). # STL allocators (T *allocator<T *>::allocate(size_type, const void*)).
# The type signature mandates a cast from uninitialized void* to T*. # The type signature mandates a cast from uninitialized void* to T*.
# size_type can either be unsigned int (j) or unsigned long (m). # size_type can either be unsigned int (j) or unsigned long (m).
fun:*8allocateEjPKv fun:*8allocateEjPKv
fun:*8allocateEmPKv fun:*8allocateEmPKv
# std::get_temporary_buffer, likewise (libstdc++, libc++). # std::get_temporary_buffer, likewise (libstdc++, libc++).
fun:_ZSt20get_temporary_buffer* fun:_ZSt20get_temporary_buffer*
Show All 14 Lines