Page MenuHomePhabricator

[Polly][ScheduleOptimizer] Translate to C++ bindings
ClosedPublic

Authored by gareevroman on Jul 25 2017, 10:13 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

gareevroman created this revision.Jul 25 2017, 10:13 AM
Meinersbur accepted this revision.Jul 25 2017, 11:29 AM

Very straightforward. ++

The only thing that surprised me was that the static keywords have been removed. I think you put those functions in unnamed namespaces instead. This is ok, but not related to the isl++ bindings. If possible, can you commit that in a separate commit?

lib/Transform/ScheduleOptimizer.cpp
560 ↗(On Diff #108108)

Why was the static removed?

Replace isl_stat by isl::stat?

639 ↗(On Diff #108108)

static?

644 ↗(On Diff #108108)

n_basic_map missing from the interface?

This revision is now accepted and ready to land.Jul 25 2017, 11:29 AM

Very straightforward. ++

Thanks for the review!

The only thing that surprised me was that the static keywords have been removed. I think you put those functions in unnamed namespaces instead. This is ok, but not related to the isl++ bindings. If possible, can you commit that in a separate commit?

Ok.

lib/Transform/ScheduleOptimizer.cpp
644 ↗(On Diff #108108)

It seems that lib/External/isl/include/isl-noexceptions.h doesn't contain it. I propose to extend the interface in a separate commit.

This revision was automatically updated to reflect the committed changes.