Translate the ScheduleOptimizer to use the new isl C++ bindings.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Very straightforward. ++
The only thing that surprised me was that the static keywords have been removed. I think you put those functions in unnamed namespaces instead. This is ok, but not related to the isl++ bindings. If possible, can you commit that in a separate commit?
lib/Transform/ScheduleOptimizer.cpp | ||
---|---|---|
560 ↗ | (On Diff #108108) | Why was the static removed? Replace isl_stat by isl::stat? |
639 ↗ | (On Diff #108108) | static? |
644 ↗ | (On Diff #108108) | n_basic_map missing from the interface? |
Thanks for the review!
The only thing that surprised me was that the static keywords have been removed. I think you put those functions in unnamed namespaces instead. This is ok, but not related to the isl++ bindings. If possible, can you commit that in a separate commit?
Ok.
lib/Transform/ScheduleOptimizer.cpp | ||
---|---|---|
644 ↗ | (On Diff #108108) | It seems that lib/External/isl/include/isl-noexceptions.h doesn't contain it. I propose to extend the interface in a separate commit. |