This is an archive of the discontinued LLVM Phabricator instance.

XFAIL tests on SLES11
ClosedPublic

Authored by bcain on Jul 24 2017, 9:04 AM.

Details

Summary

XFAIL some failing tests for SLES11 (older glibc), also replace spaces in linux distro w/dashes.

Diff Detail

Repository
rL LLVM

Event Timeline

bcain created this revision.Jul 24 2017, 9:04 AM
mclow.lists edited edge metadata.Aug 31 2017, 7:35 AM

Can you give an example of linux distro names with spaces in it?
Other than that, this looks fine to me.

utils/libcxx/test/target_info.py
193

A comment here would be helpful to future readers.

bcain added a comment.Aug 31 2017, 8:54 AM

Can you give an example of linux distro names with spaces in it?
Other than that, this looks fine to me.

platform.linux_distribution()[0] gives "SUSE Linux Enterprise Server" on SLES11.

utils/libcxx/test/target_info.py
193

How about "# some distros have spaces, lit doesn't cope well with those so we'll replace w/dashes" ?

mclow.lists added inline comments.Aug 31 2017, 9:41 AM
utils/libcxx/test/target_info.py
193

Yes. something like that. (with the SUSE example, maybe)

bcain updated this revision to Diff 113636.Sep 1 2017, 7:25 PM

Updated per review comments.

bcain marked 3 inline comments as done.Sep 1 2017, 7:26 PM

Made the recommended changes.

mclow.lists accepted this revision.Sep 5 2017, 7:34 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Sep 5 2017, 7:34 AM
bcain closed this revision.Oct 6 2017, 8:55 AM