Page MenuHomePhabricator

[Dominators] Move root-finding out of DomTreeBase and simplify it
ClosedPublic

Authored by kuhar on Jul 18 2017, 6:08 PM.

Details

Summary

This patch moves root-finding logic from DominatorTreeBase to GenericDomTreeConstruction.h.
It makes the behavior simpler and more consistent by always adding a virtual root to PostDominatorTrees.

Diff Detail

Event Timeline

kuhar created this revision.Jul 18 2017, 6:08 PM
kuhar updated this revision to Diff 107220.Jul 18 2017, 6:19 PM

Update the comment about virtual roots.

Ping. I have patches depending on this one.

dberlin accepted this revision.Jul 26 2017, 10:08 AM
This revision is now accepted and ready to land.Jul 26 2017, 10:08 AM
hiraditya added inline comments.
include/llvm/Support/GenericDomTree.h
216

s/NodeT */NodePtr

This revision was automatically updated to reflect the committed changes.