As discussed on , if the profile is compressed and llvm-profdata is not built with zlib support, the error message is not informative. Give a better error message if zlib is not available.
Yep, that'd probably be my approach - a checked in binary profile file with compressed data (including instructions in the .test file about how to reproduce the file in case anyone needs to maintain/modify/etc). (& you'll need "REQUIRES: nozlib" to ensure the test is only run when zlib is not available)
|1–10 ↗||(On Diff #107405)|
You don't need to use a prefix for these lines - since this file isn't parsed by anything except Lit and FileCheck (which both only handle lines with prefixes) any non-prefix lines are ignored/irrelevant and can be freeform.
Oh, sorry - I already approved this. Approval with comments usually means "I assume the requested changes are simple/clear/obvious enough to not require another round of review", etc.
In any case - looks good to commit after the "REGENERATE:" prefixes are removed. (did you see the discussion on the mailing list? Not all emails get reflected in Phabricator, and I replied to your question about the REGENERATE Prefix directly on the mailing list - I removed it in the other test that used it, so please remove it from this one before committing)