This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] [CMake] Build compiler-rt with no optimizations if the flag says so
ClosedPublic

Authored by george.karpenkov on Jul 13 2017, 7:19 PM.

Details

Summary

Without this change, compiler-rt gets compiled with optimizations when inside release build, even if the flag for compiling in debug mode for compiler-rt was specifically set.

Diff Detail

Repository
rL LLVM

Event Timeline

kcc accepted this revision.Jul 14 2017, 9:54 AM

LGTM
Just curious, what's the use case?

Also, please triple-check that the default build still uses -O3

This revision is now accepted and ready to land.Jul 14 2017, 9:54 AM

@kcc it's often useful to have a compiler compiled with optimizations if your tests involve compiling stuff.
Otherwise running those tests takes forever.
Yet still, even in that configuration one might wish to attach a debugger to see what symbolication/coverage instrumentation/etc is doing.

This revision was automatically updated to reflect the committed changes.