This is an archive of the discontinued LLVM Phabricator instance.

Differential D35397

ELF: Exclude dead symbols from -Map output.
ClosedPublic

Authored by pcc on Jul 13 2017, 5:21 PM.

Details

Reviewers
ruiu
Commits
rGb069a36f270b: ELF: Exclude dead symbols from -Map output.
rLLD307984: ELF: Exclude dead symbols from -Map output.
rL307984: ELF: Exclude dead symbols from -Map output.
Summary

This was previously erroring out if one of the dead symbols was a
TLS symbol and we were able to discard all TLS sections.

Diff Detail

Event Timeline

pcc created this revision.Jul 13 2017, 5:21 PM
Harbormaster completed remote builds in B8208: Diff 106566.Jul 13 2017, 5:21 PM
Herald added a subscriber: emaste. · View Herald TranscriptJul 13 2017, 5:21 PM
ruiu accepted this revision.Jul 13 2017, 5:29 PM

LGTM

lld/test/ELF/map-gc-sections.s
3

Forgot to add RUN:? You could do

ld.lld %t.o -o %t -Map=- --gc-sections | FileCheck %s
This revision is now accepted and ready to land.Jul 13 2017, 5:29 PM
Closed by commit rL307984: ELF: Exclude dead symbols from -Map output. (authored by pcc). · Explain WhyJul 13 2017, 5:32 PM
This revision was automatically updated to reflect the committed changes.
pcc marked an inline comment as done.

Revision Contents

PathSize
lld/
ELF/
2 lines
test/
ELF/
10 lines

Diff 106566

lld/ELF/MapFile.cpp

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
// Returns a list of all symbols that we want to print out. // Returns a list of all symbols that we want to print out.
template <class ELFT> std::vector<DefinedRegular *> getSymbols() { template <class ELFT> std::vector<DefinedRegular *> getSymbols() {
std::vector<DefinedRegular *> V; std::vector<DefinedRegular *> V;
for (elf::ObjectFile<ELFT> *File : Symtab<ELFT>::X->getObjectFiles()) for (elf::ObjectFile<ELFT> *File : Symtab<ELFT>::X->getObjectFiles())
for (SymbolBody *B : File->getSymbols()) for (SymbolBody *B : File->getSymbols())
if (B->File == File && !B->isSection()) if (B->File == File && !B->isSection())
if (auto *Sym = dyn_cast<DefinedRegular>(B)) if (auto *Sym = dyn_cast<DefinedRegular>(B))
if (Sym->Section) if (Sym->Section && Sym->Section->Live)
V.push_back(Sym); V.push_back(Sym);
return V; return V;
} }
// Returns a map from sections to their symbols. // Returns a map from sections to their symbols.
template <class ELFT> template <class ELFT>
SymbolMapTy getSectionSyms(ArrayRef<DefinedRegular *> Syms) { SymbolMapTy getSectionSyms(ArrayRef<DefinedRegular *> Syms) {
SymbolMapTy Ret; SymbolMapTy Ret;
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines

lld/test/ELF/map-gc-sections.s

  • This file was added.
// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
// RUN: ld.lld %t.o -o %t -Map=%t.map --gc-sections
// FileCheck %s < %t.map
ruiuUnsubmitted
Done
ReplyInline Actions

Forgot to add RUN:? You could do

ld.lld %t.o -o %t -Map=- --gc-sections | FileCheck %s
ruiu: Forgot to add `RUN:`? You could do ld.lld %t.o -o %t -Map=- --gc-sections | FileCheck %s
.section .tbss,"awT",@nobits
// CHECK-NOT: foo
.globl foo
foo:
.align 8
.long 0