Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D35349

[Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output
ClosedPublic
Actions

Authored by vladimir.plyashkun on Jul 13 2017, 4:34 AM.

Details

Reviewers
alexfh
ilya-biryukov
Commits
rG8b4fcb719777: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output
rCTE308015: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output
rL308015: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output
Summary

To get properly integration Clang-Tidy with CLion IDE, next things were implemented:

  • Preserve Message, FileOffset, FilePath in the clang-tidy output.
  • Export all diagnostics, not just the ones with fixes
  • Test-cases

Diff Detail

Repository
rL LLVM

Event Timeline

vladimir.plyashkun created this revision.Jul 13 2017, 4:34 AM
Herald added subscribers: xazax.hun, JDevlieghere, mgorny. · View Herald TranscriptJul 13 2017, 4:34 AM
vladimir.plyashkun added a comment.Jul 13 2017, 4:53 AM

This is second part of review:
https://reviews.llvm.org/D34404
which is contains changes related to clang-tools-extra repository.

Closed by commit rL308015: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output (authored by alexfh). · Explain WhyJul 14 2017, 3:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
clang-tools-extra/
trunk/
test/
clang-apply-replacements/
Inputs/
basic/
3 lines
3 lines
conflict/
3 lines
5 lines
3 lines
crlf/
5 lines
format/
7 lines
7 lines
unittests/
clang-apply-replacements/
53 lines
1 line

Diff 106609

View Options

clang-tools-extra/trunk/test/clang-apply-replacements/Inputs/basic/file1.yaml

Loading...
View Options

clang-tools-extra/trunk/test/clang-apply-replacements/Inputs/basic/file2.yaml

Loading...
View Options

clang-tools-extra/trunk/test/clang-apply-replacements/Inputs/conflict/file1.yaml

Loading...
View Options

clang-tools-extra/trunk/test/clang-apply-replacements/Inputs/conflict/file2.yaml

Loading...
View Options

clang-tools-extra/trunk/test/clang-apply-replacements/Inputs/conflict/file3.yaml

Loading...
View Options

clang-tools-extra/trunk/test/clang-apply-replacements/Inputs/crlf/file1.yaml

Loading...
View Options

clang-tools-extra/trunk/test/clang-apply-replacements/Inputs/format/no.yaml

Loading...
View Options

clang-tools-extra/trunk/test/clang-apply-replacements/Inputs/format/yes.yaml

Loading...
View Options

clang-tools-extra/trunk/unittests/clang-apply-replacements/ApplyReplacementsTest.cpp

Loading...
View Options

clang-tools-extra/trunk/unittests/clang-apply-replacements/CMakeLists.txt

Loading...