This is an archive of the discontinued LLVM Phabricator instance.

Differential D35321

[DWARF] Fix for bug processing the debug_str_offs section on Mach-O
ClosedPublic

Authored by wolfgangp on Jul 12 2017, 12:52 PM.

Details

Reviewers
dblaikie
aprantl
grimar
Commits
rG515d0e50013f: [DWARF] Fixing a bug with processing of DWARF v5 indexed strings in Mach-O…
rL307872: [DWARF] Fixing a bug with processing of DWARF v5 indexed strings in Mach-O…
Summary

This is to fix a bug with processing of DWARF v5 indexed strings in Mach-O object files. Mach-O limits section names to 16 characters, but the generic code expects DWARF v5 standard names, some of which are longer than 16 characters. Mapping of Mach-O section names to DWARF v5 standard names was implemented, but the call to the conversion routine was accidentally placed past the place where it was needed and was deemed dead code.

A test for Mach-O was added and the existing test updated.

Diff Detail

Event Timeline

wolfgangp created this revision.Jul 12 2017, 12:52 PM
dblaikie added inline comments.Jul 12 2017, 1:04 PM
test/DebugInfo/Inputs/dwarfdump-str-offsets-macho.s
1–5

Might be worth also commenting on what the original source is for ease of understanding/reading.

test/DebugInfo/dwarfdump-str-offsets.test
16–35

is theer much value in checking all of these strings? Or having such complicated code (I'd expect maybe a single subprogram - check that the DW_AT_name of the CU and of the subprogram are correct & that ought to suffice? - similarly for the second CU and type units)

87–94

Maybe SPLIT rather than ELF? (I mean, yeah, split-dwarf is only supported on ELF for now, but it'd be easier to read/understand I think, if it was clear this is a split dwarf thing, rather than an elf thing)

wolfgangp added inline comments.Jul 12 2017, 1:11 PM
test/DebugInfo/dwarfdump-str-offsets.test
16–35

I wanted to be sure to check all strx<n> forms as well as index values other than 0 and 1. Or are you just referring to the Macho-O part?

dblaikie accepted this revision.Jul 12 2017, 1:17 PM

(consider the ELF suffix rename, but otherwise looks fine)

test/DebugInfo/dwarfdump-str-offsets.test
16–35

Nah, not just Mach-O, just looking at the test in general, given all the changes.

*shrug* No big deal - I'd probably try to pare it down a bit to focus, but reasonable folks disagree about how far to go.

This revision is now accepted and ready to land.Jul 12 2017, 1:17 PM
Closed by commit rL307872: [DWARF] Fixing a bug with processing of DWARF v5 indexed strings in Mach-O… (authored by wolfgangp). · Explain WhyJul 12 2017, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
DebugInfo/
DWARF/
8 lines
test/
DebugInfo/
Inputs/
199 lines
150 lines

Diff 106267

lib/DebugInfo/DWARF/DWARFContext.cpp

Show First 20 Lines • Show All 958 Lines • ▼ Show 20 Lines if (auto Err = maybeDecompress(Section, Name, Data)) {
continue; continue;
} }
// Compressed sections names in GNU style starts from ".z", // Compressed sections names in GNU style starts from ".z",
// at this point section is decompressed and we drop compression prefix. // at this point section is decompressed and we drop compression prefix.
Name = Name.substr( Name = Name.substr(
Name.find_first_not_of("._z")); // Skip ".", "z" and "_" prefixes. Name.find_first_not_of("._z")); // Skip ".", "z" and "_" prefixes.
// Map platform specific debug section names to DWARF standard section
// names.
Name = Obj.mapDebugSectionName(Name);
if (StringRef *SectionData = mapSectionToMember(Name)) { if (StringRef *SectionData = mapSectionToMember(Name)) {
*SectionData = Data; *SectionData = Data;
if (Name == "debug_ranges") { if (Name == "debug_ranges") {
// FIXME: Use the other dwo range section when we emit it. // FIXME: Use the other dwo range section when we emit it.
RangeDWOSection.Data = Data; RangeDWOSection.Data = Data;
} }
} else if (Name == "debug_types") { } else if (Name == "debug_types") {
// Find debug_types data by section rather than name as there are // Find debug_types data by section rather than name as there are
// multiple, comdat grouped, debug_types sections. // multiple, comdat grouped, debug_types sections.
TypesSections[Section].Data = Data; TypesSections[Section].Data = Data;
} else if (Name == "debug_types.dwo") { } else if (Name == "debug_types.dwo") {
TypesDWOSections[Section].Data = Data; TypesDWOSections[Section].Data = Data;
} }
// Map platform specific debug section names to DWARF standard section
// names.
Name = Obj.mapDebugSectionName(Name);
if (RelocatedSection == Obj.section_end()) if (RelocatedSection == Obj.section_end())
continue; continue;
StringRef RelSecName; StringRef RelSecName;
StringRef RelSecData; StringRef RelSecData;
RelocatedSection->getName(RelSecName); RelocatedSection->getName(RelSecName);
// If the section we're relocating was relocated already by the JIT, // If the section we're relocating was relocated already by the JIT,
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines

test/DebugInfo/Inputs/dwarfdump-str-offsets-macho.o

  • This is a binary file.
PropertyOld ValueNew Value
svn:mime-typenullapplication/octet-stream
\ No newline at end of property

test/DebugInfo/Inputs/dwarfdump-str-offsets-macho.s

# Test object to verify dwarfdump handles v5 string offset tables in Mach-O.
#
# To generate the test object:
# llvm-mc -triple i386-apple-darwin9 dwarfdump-str-offsets-macho.s -filetype=obj \
# -o dwarfdump-str-offsets-macho.o
dblaikieUnsubmitted
Not Done
ReplyInline Actions

Might be worth also commenting on what the original source is for ease of understanding/reading.

dblaikie: Might be worth also commenting on what the original source is for ease of understanding/reading.
.section __DWARF,__debug_str,regular,debug
Linfo_string:
.asciz "Handmade DWARF producer"
str_CU1:
.asciz "Compile_Unit_1"
str_CU1_dir:
.asciz "/home/test/CU1"
str_CU2:
.asciz "Compile_Unit_2"
str_CU2_dir:
.asciz "/home/test/CU2"
str_TU:
.asciz "Type_Unit"
str_TU_type:
.asciz "MyStruct"
str_Subprogram:
.asciz "MyFunc"
str_Variable1:
.asciz "MyVar1"
str_Variable2:
.asciz "MyVar2"
str_Variable3:
.asciz "MyVar3"
.section __DWARF,__debug_str_offs,regular,debug
Ldebug_str_offsets:
.long Ldebug_str_offsets_segment0_end-Ldebug_str_offsets_base0
.short 5 # DWARF version
.short 0 # Padding
Ldebug_str_offsets_base0:
.long str_producer
.long str_CU1
.long str_CU1_dir
.long str_Subprogram
.long str_Variable1
.long str_Variable2
.long str_Variable3
Ldebug_str_offsets_segment0_end:
# CU2's contribution
.long Ldebug_str_offsets_segment1_end-Ldebug_str_offsets_base1
.short 5 # DWARF version
.short 0 # Padding
Ldebug_str_offsets_base1:
.long str_producer
.long str_CU2
.long str_CU2_dir
Ldebug_str_offsets_segment1_end:
# The TU's contribution
.long Ldebug_str_offsets_segment2_end-Ldebug_str_offsets_base2
.short 5 # DWARF version
.short 0 # Padding
Ldebug_str_offsets_base2:
.long str_TU
.long str_TU_type
Ldebug_str_offsets_segment2_end:
.section __DWARF,__debug_abbrev,regular,debug
Lsection_abbrev:
.byte 0x01 # Abbrev code
.byte 0x11 # DW_TAG_compile_unit
.byte 0x01 # DW_CHILDREN_yes
.byte 0x25 # DW_AT_producer
.byte 0x1a # DW_FORM_strx
.byte 0x03 # DW_AT_name
.byte 0x1a # DW_FORM_strx
.byte 0x72 # DW_AT_str_offsets_base
.byte 0x17 # DW_FORM_sec_offset
.byte 0x1b # DW_AT_comp_dir
.byte 0x1a # DW_FORM_strx
.byte 0x00 # EOM(1)
.byte 0x00 # EOM(2)
.byte 0x02 # Abbrev code
.byte 0x41 # DW_TAG_type_unit
.byte 0x01 # DW_CHILDREN_yes
.byte 0x03 # DW_AT_name
.byte 0x1a # DW_FORM_strx
.byte 0x72 # DW_AT_str_offsets_base
.byte 0x17 # DW_FORM_sec_offset
.byte 0x00 # EOM(1)
.byte 0x00 # EOM(2)
.byte 0x03 # Abbrev code
.byte 0x13 # DW_TAG_structure_type
.byte 0x00 # DW_CHILDREN_no (no members)
.byte 0x03 # DW_AT_name
.byte 0x1a # DW_FORM_strx
.byte 0x00 # EOM(1)
.byte 0x00 # EOM(2)
.byte 0x04 # Abbrev code
.byte 0x2e # DW_TAG_subprogram
.byte 0x01 # DW_CHILDREN_yes
.byte 0x03 # DW_AT_name
.byte 0x25 # DW_FORM_strx1
.byte 0x00 # EOM(1)
.byte 0x00 # EOM(2)
.byte 0x05 # Abbrev code
.byte 0x34 # DW_TAG_variable
.byte 0x00 # DW_CHILDREN_no
.byte 0x03 # DW_AT_name
.byte 0x26 # DW_FORM_strx2
.byte 0x00 # EOM(1)
.byte 0x00 # EOM(2)
.byte 0x06 # Abbrev code
.byte 0x34 # DW_TAG_variable
.byte 0x00 # DW_CHILDREN_no
.byte 0x03 # DW_AT_name
.byte 0x27 # DW_FORM_strx3
.byte 0x00 # EOM(1)
.byte 0x00 # EOM(2)
.byte 0x07 # Abbrev code
.byte 0x34 # DW_TAG_variable
.byte 0x00 # DW_CHILDREN_no
.byte 0x03 # DW_AT_name
.byte 0x28 # DW_FORM_strx4
.byte 0x00 # EOM(1)
.byte 0x00 # EOM(2)
.byte 0x00 # EOM(3)
.section __DWARF,__debug_info,regular,debug
Lsection_info:
# DWARF v5 CU header.
.long CU1_5_end-CU1_5_version # Length of Unit
CU1_5_version:
.short 5 # DWARF version number
.byte 1 # DWARF Unit Type
.byte 8 # Address Size (in bytes)
.long 0 # Offset Into Abbrev. Section
# The compile-unit DIE, which has a DW_AT_producer, DW_AT_name,
# DW_AT_str_offsets and DW_AT_compdir.
.byte 1 # Abbreviation code
.byte 0 # The index of the producer string
.byte 1 # The index of the CU name string
.long Ldebug_str_offsets_base0-Ldebug_str_offsets
.byte 2 # The index of the comp dir string
# A subprogram DIE with DW_AT_name, using DW_FORM_strx1.
.byte 4 # Abbreviation code
.byte 3 # Subprogram name string (DW_FORM_strx1)
# A variable DIE with DW_AT_name, using DW_FORM_strx2.
.byte 5 # Abbreviation code
.short 0x0004 # Subprogram name string (DW_FORM_strx2)
# A variable DIE with DW_AT_name, using DW_FORM_strx3.
.byte 6 # Abbreviation code
.byte 5 # Subprogram name string (DW_FORM_strx3)
.short 0 # Subprogram name string (DW_FORM_strx3)
# A variable DIE with DW_AT_name, using DW_FORM_strx4.
.byte 7 # Abbreviation code
.quad 0x00000006 # Subprogram name string (DW_FORM_strx4)
.byte 0 # NULL
.byte 0 # NULL
.byte 0 # NULL
CU1_5_end:
# DWARF v5 CU header
.long CU2_5_end-CU2_5_version # Length of Unit
CU2_5_version:
.short 5 # DWARF version number
.byte 1 # DWARF Unit Type
.byte 8 # Address Size (in bytes)
.long 0 # Offset Into Abbrev. Section
# The compile-unit DIE, which has a DW_AT_producer, DW_AT_name,
# DW_AT_str_offsets and DW_AT_compdir.
.byte 1 # Abbreviation code
.byte 0 # The index of the producer string
.byte 1 # The index of the CU name string
.long Ldebug_str_offsets_base1-Ldebug_str_offsets
.byte 2 # The index of the comp dir string
.byte 0 # NULL
CU2_5_end:
.section __DWARF,__debug_types,regular,debug
# DWARF v5 Type unit header.
TU_5_start:
.long TU_5_end-TU_5_version # Length of Unit
TU_5_version:
.short 5 # DWARF version number
.byte 2 # DWARF Unit Type
.byte 8 # Address Size (in bytes)
.long 0 # Offset Into Abbrev. Section
.quad 0x0011223344556677 # Type Signature
.long TU_5_type-TU_5_start # Type offset
# The type-unit DIE, which has a name.
.byte 2 # Abbreviation code
.byte 0 # Index of the unit type name string
.long Ldebug_str_offsets_base2-Ldebug_str_offsets # offset into the str_offsets section
# The type DIE, which has a name.
TU_5_type:
.byte 3 # Abbreviation code
.byte 1 # Index of the type name string
.byte 0 # NULL
.byte 0 # NULL
TU_5_end:
.subsections_via_symbols

test/DebugInfo/dwarfdump-str-offsets.test

RUN: llvm-dwarfdump %p/Inputs/dwarfdump-str-offsets.x86_64.o | FileCheck %s RUN: llvm-dwarfdump %p/Inputs/dwarfdump-str-offsets.x86_64.o | FileCheck --check-prefix=COMMON \
RUN: --check-prefix=ELF %s
RUN: llvm-dwarfdump %p/Inputs/dwarfdump-str-offsets-macho.o | FileCheck --check-prefix=COMMON %s
; We are using a hand-constructed object file and are interest in the correct ; We are using a hand-constructed object file and are interest in the correct
; diplay of the DW_str_offsetsbase attribute, the correct display of strings ; diplay of the DW_str_offsetsbase attribute, the correct display of strings
; and the dump of the .debug_str_offsets[.dwo] table. ; and the dump of the .debug_str_offsets[.dwo] table.
; ;
; Abbreviation for DW_AT_str_offsets_base ; Abbreviation for DW_AT_str_offsets_base
CHECK: .debug_abbrev contents: COMMON: .debug_abbrev contents:
CHECK-NOT: contents: COMMON-NOT: contents:
CHECK: DW_TAG_compile_unit COMMON: DW_TAG_compile_unit
CHECK-NOT: DW_TAG COMMON-NOT: DW_TAG
CHECK: DW_AT_str_offsets_base DW_FORM_sec_offset COMMON: DW_AT_str_offsets_base DW_FORM_sec_offset
; Verify that strings are displayed correctly as indexed strings ; Verify that strings are displayed correctly as indexed strings
CHECK: .debug_info contents: COMMON: .debug_info contents:
CHECK-NOT: contents: COMMON-NOT: contents:
CHECK: DW_TAG_compile_unit COMMON: DW_TAG_compile_unit
CHECK-NEXT: DW_AT_producer [DW_FORM_strx] ( indexed (00000000) string = "Handmade DWARF producer") COMMON-NEXT: DW_AT_producer [DW_FORM_strx] ( indexed (00000000) string = "Handmade DWARF producer")
CHECK-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000001) string = "Compile_Unit_1") COMMON-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000001) string = "Compile_Unit_1")
CHECK-NEXT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x00000008) COMMON-NEXT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x00000008)
CHECK-NEXT: DW_AT_comp_dir [DW_FORM_strx] ( indexed (00000002) string = "/home/test/CU1") COMMON-NEXT: DW_AT_comp_dir [DW_FORM_strx] ( indexed (00000002) string = "/home/test/CU1")
CHECK-NOT: NULL COMMON-NOT: NULL
CHECK: DW_TAG_subprogram COMMON: DW_TAG_subprogram
CHECK-NEXT: DW_AT_name [DW_FORM_strx1] ( indexed (00000003) string = "MyFunc") COMMON-NEXT: DW_AT_name [DW_FORM_strx1] ( indexed (00000003) string = "MyFunc")
CHECK-NOT: NULL COMMON-NOT: NULL
CHECK: DW_TAG_variable COMMON: DW_TAG_variable
CHECK-NEXT: DW_AT_name [DW_FORM_strx2] ( indexed (00000004) string = "MyVar1") COMMON-NEXT: DW_AT_name [DW_FORM_strx2] ( indexed (00000004) string = "MyVar1")
CHECK-NOT: NULL COMMON-NOT: NULL
CHECK: DW_TAG_variable COMMON: DW_TAG_variable
CHECK-NEXT: DW_AT_name [DW_FORM_strx3] ( indexed (00000005) string = "MyVar2") COMMON-NEXT: DW_AT_name [DW_FORM_strx3] ( indexed (00000005) string = "MyVar2")
CHECK-NOT: NULL COMMON-NOT: NULL
CHECK: DW_TAG_variable COMMON: DW_TAG_variable
CHECK-NEXT: DW_AT_name [DW_FORM_strx4] ( indexed (00000006) string = "MyVar3") COMMON-NEXT: DW_AT_name [DW_FORM_strx4] ( indexed (00000006) string = "MyVar3")
dblaikieUnsubmitted
Not Done
ReplyInline Actions

is theer much value in checking all of these strings? Or having such complicated code (I'd expect maybe a single subprogram - check that the DW_AT_name of the CU and of the subprogram are correct & that ought to suffice? - similarly for the second CU and type units)

dblaikie: is theer much value in checking all of these strings? Or having such complicated code (I'd…
wolfgangpAuthorUnsubmitted
Not Done
ReplyInline Actions

I wanted to be sure to check all strx<n> forms as well as index values other than 0 and 1. Or are you just referring to the Macho-O part?

wolfgangp: I wanted to be sure to check all strx<n> forms as well as index values other than 0 and 1. Or…
dblaikieUnsubmitted
Not Done
ReplyInline Actions

Nah, not just Mach-O, just looking at the test in general, given all the changes.

*shrug* No big deal - I'd probably try to pare it down a bit to focus, but reasonable folks disagree about how far to go.

dblaikie: Nah, not just Mach-O, just looking at the test in general, given all the changes. *shrug* No…
; Second compile unit (b.cpp) ; Second compile unit (b.cpp)
CHECK: DW_TAG_compile_unit COMMON: DW_TAG_compile_unit
CHECK-NEXT: DW_AT_producer [DW_FORM_strx] ( indexed (00000000) string = "Handmade DWARF producer") COMMON-NEXT: DW_AT_producer [DW_FORM_strx] ( indexed (00000000) string = "Handmade DWARF producer")
CHECK-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000001) string = "Compile_Unit_2") COMMON-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000001) string = "Compile_Unit_2")
CHECK-NEXT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x0000002c) COMMON-NEXT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x0000002c)
CHECK-NEXT: DW_AT_comp_dir [DW_FORM_strx] ( indexed (00000002) string = "/home/test/CU2") COMMON-NEXT: DW_AT_comp_dir [DW_FORM_strx] ( indexed (00000002) string = "/home/test/CU2")
; The split CU ; The split CU
CHECK: .debug_info.dwo contents: ELF: .debug_info.dwo contents:
CHECK-NOT: contents: ELF-NOT: contents:
CHECK: DW_TAG_compile_unit ELF: DW_TAG_compile_unit
CHECK-NEXT: DW_AT_producer [DW_FORM_strx] ( indexed (00000000) string = "Handmade split DWARF producer") ELF-NEXT: DW_AT_producer [DW_FORM_strx] ( indexed (00000000) string = "Handmade split DWARF producer")
CHECK-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000001) string = "V5_split_compile_unit") ELF-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000001) string = "V5_split_compile_unit")
CHECK-NEXT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x00000008) ELF-NEXT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x00000008)
CHECK-NEXT: DW_AT_comp_dir [DW_FORM_strx] ( indexed (00000002) string = "/home/test/splitCU") ELF-NEXT: DW_AT_comp_dir [DW_FORM_strx] ( indexed (00000002) string = "/home/test/splitCU")
; The type unit ; The type unit
CHECK: .debug_types contents: COMMON: .debug_types contents:
CHECK: DW_TAG_type_unit COMMON: DW_TAG_type_unit
CHECK-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000000) string = "Type_Unit") COMMON-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000000) string = "Type_Unit")
CHECK-NEXT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x00000040) COMMON-NEXT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x00000040)
CHECK: DW_TAG_structure_type COMMON: DW_TAG_structure_type
CHECK-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000001) string = "MyStruct") COMMON-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000001) string = "MyStruct")
; The split type unit ; The split type unit
CHECK: .debug_types.dwo contents: ELF: .debug_types.dwo contents:
CHECK: DW_TAG_type_unit ELF: DW_TAG_type_unit
CHECK-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000000) string = "V5_split_type_unit") ELF-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000000) string = "V5_split_type_unit")
CHECK-NEXT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x0000001c) ELF-NEXT: DW_AT_str_offsets_base [DW_FORM_sec_offset] (0x0000001c)
CHECK: DW_TAG_structure_type ELF: DW_TAG_structure_type
CHECK-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000001) string = "V5_split_Mystruct") ELF-NEXT: DW_AT_name [DW_FORM_strx] ( indexed (00000001) string = "V5_split_Mystruct")
; The .debug_str_offsets section ; The .debug_str_offsets section
CHECK: .debug_str_offsets contents: COMMON: .debug_str_offsets contents:
CHECK-NEXT: 0x00000000: Contribution size = 28, Version = 5 COMMON-NEXT: 0x00000000: Contribution size = 28, Version = 5
CHECK-NEXT: 0x00000008: 00000000 "Handmade DWARF producer" COMMON-NEXT: 0x00000008: 00000000 "Handmade DWARF producer"
CHECK-NEXT: 0x0000000c: 00000018 "Compile_Unit_1" COMMON-NEXT: 0x0000000c: 00000018 "Compile_Unit_1"
CHECK-NEXT: 0x00000010: 00000027 "/home/test/CU1" COMMON-NEXT: 0x00000010: 00000027 "/home/test/CU1"
CHECK-NEXT: 0x00000014: 00000067 "MyFunc" COMMON-NEXT: 0x00000014: 00000067 "MyFunc"
CHECK-NEXT: 0x00000018: 0000006e "MyVar1" COMMON-NEXT: 0x00000018: 0000006e "MyVar1"
CHECK-NEXT: 0x0000001c: 00000075 "MyVar2" COMMON-NEXT: 0x0000001c: 00000075 "MyVar2"
CHECK-NEXT: 0x00000020: 0000007c "MyVar3" COMMON-NEXT: 0x00000020: 0000007c "MyVar3"
CHECK-NEXT: 0x00000024: Contribution size = 12, Version = 5 COMMON-NEXT: 0x00000024: Contribution size = 12, Version = 5
CHECK-NEXT: 0x0000002c: 00000000 "Handmade DWARF producer" COMMON-NEXT: 0x0000002c: 00000000 "Handmade DWARF producer"
CHECK-NEXT: 0x00000030: 00000036 "Compile_Unit_2" COMMON-NEXT: 0x00000030: 00000036 "Compile_Unit_2"
CHECK-NEXT: 0x00000034: 00000045 "/home/test/CU2" COMMON-NEXT: 0x00000034: 00000045 "/home/test/CU2"
CHECK-NEXT: 0x00000038: Contribution size = 8, Version = 5 COMMON-NEXT: 0x00000038: Contribution size = 8, Version = 5
CHECK-NEXT: 0x00000040: 00000054 "Type_Unit" COMMON-NEXT: 0x00000040: 00000054 "Type_Unit"
CHECK-NEXT: 0x00000044: 0000005e "MyStruct" COMMON-NEXT: 0x00000044: 0000005e "MyStruct"
CHECK: .debug_str_offsets.dwo contents: ELF: .debug_str_offsets.dwo contents:
CHECK-NEXT: 0x00000000: Contribution size = 12, Version = 5 ELF-NEXT: 0x00000000: Contribution size = 12, Version = 5
CHECK-NEXT: 0x00000008: 00000000 "Handmade split DWARF producer" ELF-NEXT: 0x00000008: 00000000 "Handmade split DWARF producer"
CHECK-NEXT: 0x0000000c: 0000001e "V5_split_compile_unit" ELF-NEXT: 0x0000000c: 0000001e "V5_split_compile_unit"
CHECK-NEXT: 0x00000010: 00000034 "/home/test/splitCU" ELF-NEXT: 0x00000010: 00000034 "/home/test/splitCU"
CHECK-NEXT: 0x00000014: Contribution size = 8, Version = 5 ELF-NEXT: 0x00000014: Contribution size = 8, Version = 5
CHECK-NEXT: 0x0000001c: 00000047 "V5_split_type_unit" ELF-NEXT: 0x0000001c: 00000047 "V5_split_type_unit"
CHECK-NEXT: 0x00000020: 0000005a "V5_split_Mystruct" ELF-NEXT: 0x00000020: 0000005a "V5_split_Mystruct"
dblaikieUnsubmitted
Not Done
ReplyInline Actions

Maybe SPLIT rather than ELF? (I mean, yeah, split-dwarf is only supported on ELF for now, but it'd be easier to read/understand I think, if it was clear this is a split dwarf thing, rather than an elf thing)

dblaikie: Maybe SPLIT rather than ELF? (I mean, yeah, split-dwarf is only supported on ELF for now, but…