This is an archive of the discontinued LLVM Phabricator instance.

[mips][mt][2/7] Implement .module and .set directives for the MT ASE.
ClosedPublic

Authored by sdardis on Jul 11 2017, 4:58 AM.

Details

Summary

This patch implements the .module and .set directives for the MT ASE,
notably that .module sets the relevant flags in .MIPS.abiflags and .set
doesn't.

Event Timeline

sdardis created this revision.Jul 11 2017, 4:58 AM
sdardis added inline comments.Jul 11 2017, 4:58 AM
lib/Target/Mips/AsmParser/MipsAsmParser.cpp
7231

I've just spotted the spelling error here, will fix later.

sdardis retitled this revision from [mips][mt][2/8] Implement .module and .set directives for the MT ASE. to [mips][mt][2/7] Implement .module and .set directives for the MT ASE..Jul 11 2017, 5:08 AM
atanasyan accepted this revision.Jul 11 2017, 6:28 AM

LGTM

test/MC/Mips/mt/module-directive.s
2

I would try to use llvm-readobj -mips-abi-flags to check the .MIPS.abiflags section content.

test/MC/Mips/mt/set-directive.s
2

and ditto here.

This revision is now accepted and ready to land.Jul 11 2017, 6:28 AM
This revision was automatically updated to reflect the committed changes.