[lld/pdb] Create an empty public symbol records stream
ClosedPublic

Authored by zturner on Jul 10 2017, 3:03 PM.

Details

Summary

This creates a public symbol hash stream and public symbol records stream, each completely empty. This allows us to get more fields matching up in the pdb diff test, so that test is updated.

Eventually we will need to come up with a clever algorithm for diffing symbol records, but for now at least this gets us one step closer.

link still doesn't like our PDBs even after this change, so the next thing to check would be creating an empty globals stream.

Diff Detail

Repository
rL LLVM
zturner created this revision.Jul 10 2017, 3:03 PM
ruiu accepted this revision.Jul 10 2017, 3:09 PM

LGTM. It looks pretty straightforward.

llvm/include/llvm/DebugInfo/PDB/Native/PublicsStreamBuilder.h
31 ↗(On Diff #105925)

explicit?

This revision is now accepted and ready to land.Jul 10 2017, 3:09 PM
amccarth added inline comments.
lld/COFF/PDB.cpp
484 ↗(On Diff #105925)

The patch summary is a clearer than this comment. At a minimum, "stream" should be plural.

This revision was automatically updated to reflect the committed changes.