[cfi] only add cfi tests on supported arches

[sfertile]

Summary

I've recently discovered that the cfi tests are [sometimes] being run on powerpc64le despite it not being one of the supported arches. I only noticed when I started building the gold plugin since the cfi tests that don't require the plugin are passing, but if I build the plugin I get 22 unexpected failures in the lit run.

My attempt at a fix is to only add the tests for supported architectures.

[eugenis]

test/cfi/CMakeLists.txt

47

CFI_TEST_ARCH is set to CFI_SUPPORTED_ARCH. Why are you testing that ${arch} is in CFI_SUPPORTED_ARCH here?

49

If there are multiple supported arches, like i686 and x86_64, this would create exactly the same test suites twice, right?

[sfertile]

Removed unnecessary loop.

[eugenis]

test/cfi/CMakeLists.txt

39

replace with "if (CFI_SUPPORTED_ARCH)" so that it is not limited to Linux.

test/cfi/CMakeLists.txt

 
 if (APPLE)
   # FIXME: enable ThinLTO tests after fixing http://llvm.org/pr32741
   add_cfi_test_suites(False False)
 elseif(WIN32)
   # FIXME: enable ThinLTO tests after fixing http://llvm.org/pr32770
   add_cfi_test_suites(True False)
 else()
+  if (COMPILER_RT_HAS_CFI)
     add_cfi_test_suites(False False)
     add_cfi_test_suites(False True)
     if (COMPILER_RT_HAS_LLD)
       add_cfi_test_suites(True False)
       add_cfi_test_suites(True True)
     endif()
   endif()
+endif()
 
 set(CFI_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
 list(APPEND CFI_TEST_DEPS
   ubsan
   stats
 )
 if(COMPILER_RT_HAS_CFI)
   list(APPEND CFI_TEST_DEPS cfi)
 endif()