This is an archive of the discontinued LLVM Phabricator instance.

[cfi] only add cfi tests on supported arches
ClosedPublic

Authored by sfertile on Jul 6 2017, 7:46 PM.

Details

Summary

I've recently discovered that the cfi tests are [sometimes] being run on powerpc64le despite it not being one of the supported arches. I only noticed when I started building the gold plugin since the cfi tests that don't require the plugin are passing, but if I build the plugin I get 22 unexpected failures in the lit run.

My attempt at a fix is to only add the tests for supported architectures.

Diff Detail

Repository
rL LLVM

Event Timeline

sfertile created this revision.Jul 6 2017, 7:46 PM
eugenis added inline comments.Jul 28 2017, 4:32 PM
test/cfi/CMakeLists.txt
47

CFI_TEST_ARCH is set to CFI_SUPPORTED_ARCH. Why are you testing that ${arch} is in CFI_SUPPORTED_ARCH here?

49

If there are multiple supported arches, like i686 and x86_64, this would create exactly the same test suites twice, right?

sfertile updated this revision to Diff 109596.Aug 3 2017, 10:56 AM

Removed unnecessary loop.

sfertile marked 2 inline comments as done.Aug 3 2017, 10:57 AM
eugenis accepted this revision.Aug 3 2017, 1:26 PM
eugenis added inline comments.
test/cfi/CMakeLists.txt
39

replace with "if (CFI_SUPPORTED_ARCH)" so that it is not limited to Linux.

This revision is now accepted and ready to land.Aug 3 2017, 1:26 PM
This revision was automatically updated to reflect the committed changes.