Page MenuHomePhabricator

[OpenCL] Generalise err_opencl_enqueue_kernel_expected_type to be used with other builtins
ClosedPublic

Authored by joey on Jul 3 2017, 7:48 AM.

Details

Reviewers
bader
Summary

Refactor err_opencl_enqueue_kernel_expected_type so that other builtins can use the same diagnostic.

Diff Detail

Event Timeline

joey created this revision.Jul 3 2017, 7:48 AM
bader accepted this revision.Jul 3 2017, 9:00 AM

LGTM.
Do you have another built-in in mind which can use this diagnostic message?
If so, it would make sense to re-use it in the same patch.

This revision is now accepted and ready to land.Jul 3 2017, 9:00 AM
joey added a comment.Jul 3 2017, 9:14 AM

LGTM.
Do you have another built-in in mind which can use this diagnostic message?
If so, it would make sense to re-use it in the same patch.

This is split off from https://reviews.llvm.org/D33945, which I will be rebasing/re-uploading once this patch is committed.

bader added a comment.Jul 4 2017, 3:06 AM

Do you have another built-in in mind which can use this diagnostic message?
If so, it would make sense to re-use it in the same patch.

This is split off from https://reviews.llvm.org/D33945, which I will be rebasing/re-uploading once this patch is committed.

I see. Thanks for clarification.
No other comments from my side.

joey closed this revision.Jul 4 2017, 7:34 AM