Page MenuHomePhabricator

[DWARFCallFrameInfo] Add Type enum to differentiate eh/debug_frame sections
ClosedPublic

Authored by labath on Jun 27 2017, 4:33 AM.

Details

Summary

instead of using a boolean to differentiate between the two section
types, use an enum to make the intent clearer.

I also remove the RegisterKind argument from the constructor, as this
can be deduced from the Type argument.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Jun 27 2017, 4:33 AM
clayborg accepted this revision.Jun 27 2017, 9:44 AM

Looks good.

This revision is now accepted and ready to land.Jun 27 2017, 9:44 AM

Saying about clear intent, it would be even much more better if class name doesn't start with DWARF ;)

Saying about clear intent, it would be even much more better if class name doesn't start with DWARF ;)

That's probably true. :) However, I think I've done enough of renaming of files lately that I will pass on this one for now.

This revision was automatically updated to reflect the committed changes.