This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Add a test for associative map proto buffer fields
ClosedPublic

Authored by krasimir on Jun 26 2017, 8:00 AM.

Download Raw Diff

Details

Reviewers

Commits

rG9451e67158d2: [clang-format] Add a test for associative map proto buffer fields
rC306386: [clang-format] Add a test for associative map proto buffer fields
rL306386: [clang-format] Add a test for associative map proto buffer fields

Summary

The test suite was missing a test about associative maps:
https://developers.google.com/protocol-buffers/docs/proto3#maps

Diff Detail

Build Status

Buildable 7600
Build 7600: arc lint + arc unit

Event Timeline

krasimir created this revision.Jun 26 2017, 8:00 AM

Herald added a subscriber: klimek. · View Herald TranscriptJun 26 2017, 8:00 AM

krasimir added a reviewer: djasper.Jun 26 2017, 8:01 AM

krasimir added a subscriber: cfe-commits.

Can you create a more interesting test case where the map definition spans multiple lines? Possibly use qualified names for the field types.

Add map declarations spanning multiple lines

Looks good. Thank you!

This revision is now accepted and ready to land.Jun 27 2017, 2:49 AM

Closed by commit rL306386: [clang-format] Add a test for associative map proto buffer fields (authored by krasimir). · Explain WhyJun 27 2017, 3:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

unittests/

Format/

FormatTestProto.cpp

23 lines

Diff 103962

unittests/Format/FormatTestProto.cpp

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines	TEST_F(FormatTestProto, FormatsMessages) {

verifyFormat("message SomeMessage {\n"		verifyFormat("message SomeMessage {\n"
" optional really.really.long.qualified.type.aaa.aaaaaaa\n"		" optional really.really.long.qualified.type.aaa.aaaaaaa\n"
" fiiiiiiiiiiiiiiiiiiiiiiiiield = 1;\n"		" fiiiiiiiiiiiiiiiiiiiiiiiiield = 1;\n"
" optional\n"		" optional\n"
" really.really.long.qualified.type.aaa.aaaaaaa.aaaaaaaa\n"		" really.really.long.qualified.type.aaa.aaaaaaa.aaaaaaaa\n"
" another_fiiiiiiiiiiiiiiiiiiiiield = 2;\n"		" another_fiiiiiiiiiiiiiiiiiiiiield = 2;\n"
"}");		"}");
		verifyFormat("message SomeMessage {\n"
		" map<string, Project> projects = 1;\n"
		" optional map<string, int32> size_projects = 2;\n"
		" map<int, really.really.really.long.qualified.type.nameeee>\n"
		" projects = 3;\n"
		" map<int, really.really.really.really.long.qualified.type\n"
		" .nameeee> projects = 4;\n"
		" map<int,\n"
		" reallyreallyreallyreallyreallyreallyreallylongname>\n"
		" projects = 5;\n"
		" map<int, Project>\n"
		" longlonglonglonglonglonglonglonglonglongonglon = 6;\n"
		" map<releleallyreallyreallyreallyreallyreallyreallylongname,\n"
		" int> projects = 7;\n"
		" map<releleallyreallyreallyreallyreallyreallyreallylongname,\n"
		" releleallyreallyreallyreallyreallyreallyreallylongname>\n"
		" releleallyreallyreallyreallyreallyreallyreallylongnam =\n"
		" 8;\n"
		" map<relele.llyreal.yreallyr.allyreally.eallyreal\n"
		" .sauenirylongname,\n"
		" really.really.really.really.long.qualified.type\n"
		" .nameeee> projects = 9;\n"
		"}");
}		}

TEST_F(FormatTestProto, KeywordsInOtherLanguages) {		TEST_F(FormatTestProto, KeywordsInOtherLanguages) {
verifyFormat("optional string operator = 1;");		verifyFormat("optional string operator = 1;");
}		}

TEST_F(FormatTestProto, FormatsEnums) {		TEST_F(FormatTestProto, FormatsEnums) {
verifyFormat("enum Type {\n"		verifyFormat("enum Type {\n"
▲ Show 20 Lines • Show All 153 Lines • Show Last 20 Lines