This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Support <>-style proto message fields
ClosedPublic

Authored by krasimir on Jun 26 2017, 7:39 AM.

Details

Summary

This patch adds support for <>-style proto message fields inside proto options.
Previously these were wrongly treated as binary operators and as such were
working only by chance for a limited number of cases.

Event Timeline

krasimir created this revision.Jun 26 2017, 7:39 AM
krasimir updated this revision to Diff 103949.Jun 26 2017, 7:43 AM
  • Fixed newlines
krasimir added a subscriber: cfe-commits.
krasimir updated this revision to Diff 104146.Jun 27 2017, 6:13 AM
  • Rebase with master
  • Updated implementation with the new tests
krasimir updated this revision to Diff 104148.Jun 27 2017, 6:15 AM
  • Remove todo test case
djasper accepted this revision.Jun 27 2017, 6:30 AM

Looks good.

This revision is now accepted and ready to land.Jun 27 2017, 6:30 AM
This revision was automatically updated to reflect the committed changes.