This is an archive of the discontinued LLVM Phabricator instance.

[Reassociate] Make sure EraseInst sets MadeChange
ClosedPublic

Authored by uabelho on Jun 26 2017, 6:07 AM.

Details

Summary

EraseInst didn't report that it made IR changes through MadeChange.

It is essential that changes to the IR are reported correctly,
since for example ReassociatePass::run() will indicate that all
analyses are preserved otherwise.
And the CGPassManager determines if the CallGraph is up-to-date
based on status from InstructionCombiningPass::runOnFunction().

Diff Detail

Event Timeline

uabelho created this revision.Jun 26 2017, 6:07 AM

Similar to https://reviews.llvm.org/D34346, but for reassociate instead of instcombine.

uabelho updated this revision to Diff 103936.Jun 26 2017, 6:17 AM
uabelho edited the summary of this revision. (Show Details)

Fixed typos in commit message and test case.

rnk accepted this revision.Jun 26 2017, 8:23 AM

lgtm

This revision is now accepted and ready to land.Jun 26 2017, 8:23 AM
davide accepted this revision.Jun 26 2017, 6:02 PM

This change looks fine.

This revision was automatically updated to reflect the committed changes.