This is an archive of the discontinued LLVM Phabricator instance.

Remove /nologo from windows build
AbandonedPublic

Authored by TyanNN on Jun 22 2017, 10:57 AM.

Details

Summary

/nologo emits error on new versions of rc.exe
PR#33493

Diff Detail

Event Timeline

TyanNN created this revision.Jun 22 2017, 10:57 AM

I am mildly curious how much noise this adds to a build log.

cmake/modules/AddLLVM.cmake
675

Usually whitespace/formatting fixes are done separately.

1331

Usually whitespace/formatting fixes are done separately.

TyanNN added a comment.EditedJun 24 2017, 2:37 AM

I am mildly curious how much noise this adds to a build log.

Well, that's not really what i intended to do, it's just emacs save-hook that strips spaces at the end of the line, if it's necessary, i might disable it and update the patch

TyanNN abandoned this revision.Jul 11 2017, 10:51 PM