This is an archive of the discontinued LLVM Phabricator instance.

Differential D34520

Minor correctness improvements for LLVMTestingSupport
AcceptedPublic

Authored by zturner on Jun 22 2017, 10:54 AM.

Download Raw Diff

Details

Reviewers

Diff Detail

Event Timeline

zturner created this revision.Jun 22 2017, 10:54 AM

Herald added subscribers: hiraditya, mgorny. · View Herald TranscriptJun 22 2017, 10:54 AM

chapuni added a subscriber: chapuni.Jun 22 2017, 3:30 PM

LGTM!

This revision is now accepted and ready to land.Jul 7 2017, 11:14 AM

chapuni added inline comments.Jul 9 2017, 6:20 AM

llvm/lib/CMakeLists.txt
33	Could you add linefeed at eof?
llvm/lib/Testing/Support/CMakeLists.txt
12	In general, I recommend; INTERFACE in static library PRIVATE in SHARED library (BUILD_SHARED_LIBS=ON) llvm_add_library(LINK_LIBS) does.

Revision Contents

Path

Size

llvm/

lib/

7 lines

Testing/

Support/

2 lines

Diff 103603

llvm/lib/CMakeLists.txt

	Show All 18 Lines
	add_subdirectory(Target)			add_subdirectory(Target)
	add_subdirectory(AsmParser)			add_subdirectory(AsmParser)
	add_subdirectory(LineEditor)			add_subdirectory(LineEditor)
	add_subdirectory(ProfileData)			add_subdirectory(ProfileData)
	add_subdirectory(Fuzzer)			add_subdirectory(Fuzzer)
	add_subdirectory(Passes)			add_subdirectory(Passes)
	add_subdirectory(ToolDrivers)			add_subdirectory(ToolDrivers)
	add_subdirectory(XRay)			add_subdirectory(XRay)

				if (LLVM_INCLUDE_TESTS AND LLVM_INCLUDE_UTILS)
				# Testing library depends on gtest, which is only included if
				# both of these variables are ON.
	add_subdirectory(Testing)			add_subdirectory(Testing)
				endif()
				No newline at end of file
				chapuniUnsubmitted Not Done Reply Inline Actions Could you add linefeed at eof? chapuni: Could you add linefeed at eof?

llvm/lib/Testing/Support/CMakeLists.txt

	add_llvm_library(LLVMTestingSupport			add_llvm_library(LLVMTestingSupport
	Error.cpp			Error.cpp

	BUILDTREE_ONLY			BUILDTREE_ONLY

	ADDITIONAL_HEADER_DIRS			ADDITIONAL_HEADER_DIRS
	${LLVM_MAIN_INCLUDE_DIR}/llvm/Testing/Support			${LLVM_MAIN_INCLUDE_DIR}/llvm/Testing/Support
	)			)

	include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest/include)			include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest/include)
	include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googlemock/include)			include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googlemock/include)
	target_link_libraries(LLVMTestingSupport PRIVATE gtest)			target_link_libraries(LLVMTestingSupport INTERFACE gtest)
				chapuniUnsubmitted Not Done Reply Inline Actions In general, I recommend; INTERFACE in static library PRIVATE in SHARED library (BUILD_SHARED_LIBS=ON) llvm_add_library(LINK_LIBS) does. chapuni: In general, I recommend; INTERFACE in static library PRIVATE in SHARED library…
	No newline at end of file			No newline at end of file