This is an archive of the discontinued LLVM Phabricator instance.

Minor correctness improvements for LLVMTestingSupport
AcceptedPublic

Authored by zturner on Jun 22 2017, 10:54 AM.

Details

Reviewers
beanz

Diff Detail

Event Timeline

zturner created this revision.Jun 22 2017, 10:54 AM
beanz accepted this revision.Jul 7 2017, 11:14 AM

LGTM!

This revision is now accepted and ready to land.Jul 7 2017, 11:14 AM
chapuni added inline comments.Jul 9 2017, 6:20 AM
llvm/lib/CMakeLists.txt
33

Could you add linefeed at eof?

llvm/lib/Testing/Support/CMakeLists.txt
12

In general, I recommend;
INTERFACE in static library
PRIVATE in SHARED library (BUILD_SHARED_LIBS=ON)

llvm_add_library(LINK_LIBS) does.