Page MenuHomePhabricator

Move Connection from Core to Host
ClosedPublic

Authored by labath on Jun 20 2017, 5:56 AM.

Details

Summary

All implementations of the connection interface live in the Host module
already, so it makes sense for the interface itself to be defined there.

Event Timeline

labath created this revision.Jun 20 2017, 5:56 AM
labath updated this revision to Diff 103971.Jun 26 2017, 9:04 AM

This is how things would look like if we move Connection to Utility instead. I
needed to do two things to make this happen:

  • Keep Connection::CreateDefaultConnection in Host (now known as Host::CreateDefaultConnection), because this actually creates concrete instances).
  • Move IOObject to Utility as well. Connection interface was depending on this class. Although theoretically a forward declaration could suffice, we still shouldn't depend on stuff forward-declared in another module. The same rationale can apply to this class as well -- it's an abstract interface, which can live in Utility, and all concrete instances can (hopefully) stay in Host.
zturner accepted this revision.Jun 26 2017, 10:09 AM

Nice, yea this will be a big help I think.

This revision is now accepted and ready to land.Jun 26 2017, 10:09 AM
This revision was automatically updated to reflect the committed changes.