This is an archive of the discontinued LLVM Phabricator instance.

In D34303#782959, @davide wrote:

In D34303#782953, @craig.topper wrote:

Is that the wrong bug link in the description?

Oh, yes, sigh :( https://bugs.llvm.org//show_bug.cgi?id=33453

Thanks for catching it, I amended my commit message :)

Closed by commit rL305618: [InstCombine] Make FPMathOperator working with ConstantExpression(s). (authored by davide). · Explain WhyJun 16 2017, 5:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

include/

llvm/

IR/

Operator.h

9 lines

test/

Transforms/

InstCombine/

pr33453.ll

15 lines

Diff 102910

llvm/trunk/include/llvm/IR/Operator.h

Show First 20 Lines • Show All 322 Lines • ▼ Show 20 Lines	public:
/// 0.0 means that the operation should be performed with the default		/// 0.0 means that the operation should be performed with the default
/// precision.		/// precision.
float getFPAccuracy() const;		float getFPAccuracy() const;

static inline bool classof(const Instruction *I) {		static inline bool classof(const Instruction *I) {
return I->getType()->isFPOrFPVectorTy() \|\|		return I->getType()->isFPOrFPVectorTy() \|\|
I->getOpcode() == Instruction::FCmp;		I->getOpcode() == Instruction::FCmp;
}		}

		static inline bool classof(const ConstantExpr *CE) {
		return CE->getType()->isFPOrFPVectorTy() \|\|
		CE->getOpcode() == Instruction::FCmp;
		}

static inline bool classof(const Value *V) {		static inline bool classof(const Value *V) {
return isa<Instruction>(V) && classof(cast<Instruction>(V));		return (isa<Instruction>(V) && classof(cast<Instruction>(V))) \|\|
		(isa<ConstantExpr>(V) && classof(cast<ConstantExpr>(V)));
}		}
};		};

/// A helper template for defining operators for individual opcodes.		/// A helper template for defining operators for individual opcodes.
template<typename SuperClass, unsigned Opc>		template<typename SuperClass, unsigned Opc>
class ConcreteOperator : public SuperClass {		class ConcreteOperator : public SuperClass {
public:		public:
static inline bool classof(const Instruction *I) {		static inline bool classof(const Instruction *I) {
▲ Show 20 Lines • Show All 184 Lines • Show Last 20 Lines

llvm/trunk/test/Transforms/InstCombine/pr33453.ll

				; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
				; RUN: opt -instcombine -S %s \| FileCheck %s

				@g1 = external global i16
				@g2 = external global i16

				define float @patatino() {
				; CHECK-LABEL: @patatino(
				; CHECK-NEXT: ret float fmul (float uitofp (i1 icmp eq (i16* getelementptr inbounds (i16, i16* @g2, i64 1), i16* @g1) to float), float uitofp (i1 icmp eq (i16* getelementptr inbounds (i16, i16* @g2, i64 1), i16* @g1) to float))
				;
				%call = call float @fabsf(float fmul (float uitofp (i1 icmp eq (i16* getelementptr inbounds (i16, i16* @g2, i64 1), i16* @g1) to float), float uitofp (i1 icmp eq (i16* getelementptr inbounds (i16, i16* @g2, i64 1), i16* @g1) to float)))
				ret float %call
				}

				declare float @fabsf(float)

This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Make FPMathOperator working with ConstantExpressionClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 102910

llvm/trunk/include/llvm/IR/Operator.h

llvm/trunk/test/Transforms/InstCombine/pr33453.ll

[InstCombine] Make FPMathOperator working with ConstantExpression
ClosedPublic