This patch exposes the exception specification type (noexcept, etc.) of a C++ function through libclang and Python clang.cindex.
Details
Diff Detail
Event Timeline
include/clang-c/Index.h | ||
---|---|---|
185 | You can drop the trailing comment. | |
208 | Spurious trailing full stop. | |
213 | Same here. | |
test/Index/get-cursor.cpp | ||
152 | The comment isn't helpful and can be removed. | |
tools/libclang/CXType.cpp | ||
689 | Can elide the braces. | |
693 | Use const auto * and elide the braces. | |
695 | No else after a return; you can just lower this into the function scope and remove the else. | |
703 | No else after a return and can elide the braces for the if. |
include/clang-c/Index.h | ||
---|---|---|
213 | This comment is now missing the full-stop at the end of the sentence (you dropped one too many periods). | |
tools/libclang/CXType.cpp | ||
693 | You should run your patch through clang-format; the asterisk should bind to FD rather than auto and the indentation is too large in the patch. |
This patch has introduced a test suite failure:
====================================================================== ERROR: Failure: ImportError (No module named util) ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib64/python2.7/site-packages/nose/loader.py", line 420, in loadTestsFromName addr.filename, addr.module) File "/usr/lib64/python2.7/site-packages/nose/importer.py", line 47, in importFromPath return self.importFromDir(dir_path, fqname) File "/usr/lib64/python2.7/site-packages/nose/importer.py", line 94, in importFromDir mod = load_module(part_fqname, fh, filename, desc) File "/usr/src/llvm/tools/clang/bindings/python/tests/test_exception_specification_kind.py", line 3, in <module> from .util import get_tu ImportError: No module named util
I presume that this patch meant to include the util module but you forgot to add the file. Could you fix that, please?
cfe/trunk/bindings/python/tests/test_exception_specification_kind.py | ||
---|---|---|
3 ↗ | (On Diff #104301) | It seems that the util module has never been committed. |
You can drop the trailing comment.