[codeview] use 32-bit integer for RelocOffset in DebugLinesSubsection

[inglorion]

Summary

RelocOffset is a 32-bit value, but we previously truncated it to 16 bits.

Fixes PR33335.

[chapuni]

llvm/trunk/test/DebugInfo/PDB/Inputs/debug-subsections.yaml

41 ↗

(On Diff #101986)

Didn't you update corresponding testcase? See also rL305063.

[inglorion]

llvm/trunk/test/DebugInfo/PDB/Inputs/debug-subsections.yaml

41 ↗

(On Diff #101986)

Yes. Thanks for fixing that.

llvm/include/llvm/DebugInfo/CodeView/DebugLinesSubsection.h

public:
   void createBlock(StringRef FileName);
   void addLineInfo(uint32_t Offset, const LineInfo &Line);
   void addLineAndColumnInfo(uint32_t Offset, const LineInfo &Line,
                             uint32_t ColStart, uint32_t ColEnd);
 
   uint32_t calculateSerializedSize() const override;
   Error commit(BinaryStreamWriter &Writer) const override;
 
-  void setRelocationAddress(uint16_t Segment, uint16_t Offset);
+  void setRelocationAddress(uint16_t Segment, uint32_t Offset);
   void setCodeSize(uint32_t Size);
   void setFlags(LineFlags Flags);
 
   bool hasColumnInfo() const;
 
 private:
   DebugChecksumsSubsection &Checksums;
 
-  uint16_t RelocOffset = 0;
+  uint32_t RelocOffset = 0;
   uint16_t RelocSegment = 0;
   uint32_t CodeSize = 0;
   LineFlags Flags = LF_None;
   std::vector<Block> Blocks;
 };
 }
 }
 
 #endif

llvm/lib/DebugInfo/CodeView/DebugLinesSubsection.cpp

for (const auto &B : Blocks) {
     Size += B.Lines.size() * sizeof(LineNumberEntry);
     if (hasColumnInfo())
       Size += B.Columns.size() * sizeof(ColumnNumberEntry);
   }
   return Size;
 }
 
 void DebugLinesSubsection::setRelocationAddress(uint16_t Segment,
-                                                uint16_t Offset) {
+                                                uint32_t Offset) {
   RelocOffset = Offset;
   RelocSegment = Segment;
 }
 
 void DebugLinesSubsection::setCodeSize(uint32_t Size) { CodeSize = Size; }
 
 void DebugLinesSubsection::setFlags(LineFlags Flags) { this->Flags = Flags; }
 
 bool DebugLinesSubsection::hasColumnInfo() const {
   return Flags & LF_HaveColumns;
 }

llvm/test/DebugInfo/PDB/Inputs/simple-line-info.yaml

- Module:          'd:\src\llvm\test\DebugInfo\PDB\Inputs\empty.obj'
               Kind:            MD5
               Checksum:        A0A5BD0D3ECD93FC29D19DE826FBF4BC
             - FileName:        'f:\dd\externalapis\windows\10\sdk\inc\winerror.h'
               Kind:            MD5
               Checksum:        1154D69F5B2650196E1FC34F4134E56B
         - !Lines
           CodeSize:        10
           Flags:           [  ]
-          RelocOffset:     16
+          RelocOffset:     100016
           RelocSegment:    1
           Blocks:
             - FileName:        'd:\src\llvm\test\debuginfo\pdb\inputs\empty.cpp'
               Lines:
                 - Offset:          0
                   LineStart:       5
                   IsStatement:     true
                   EndDelta:        0

llvm/test/DebugInfo/PDB/pdbdump-yaml-lineinfo-write.test

 LINES-NEXT:            Checksum (
 LINES-NEXT:              0000: 1154D69F 5B265019 6E1FC34F 4134E56B  |.T..[&P.n..OA4.k|
 LINES-NEXT:            )
 LINES-NEXT:          }
 LINES-NEXT:        }
 LINES-NEXT:        Lines {
 LINES-NEXT:          Block {
 LINES-NEXT:            RelocSegment: 1
-LINES-NEXT:            RelocOffset: 16
+LINES-NEXT:            RelocOffset: 100016
 LINES-NEXT:            CodeSize: 10
 LINES-NEXT:            HasColumns: No
 LINES-NEXT:            Lines {
 LINES-NEXT:              FileName: d:\src\llvm\test\debuginfo\pdb\inputs\empty.cpp
 LINES-NEXT:              Line {
 LINES-NEXT:                Offset: 0
 LINES-NEXT:                LineNumberStart: 5
 LINES-NEXT:                EndDelta: 0