This is an archive of the discontinued LLVM Phabricator instance.

[DWARF] Introduce Dump Options
ClosedPublic

Authored by sgravani on May 31 2017, 5:15 PM.

Details

Summary

I'm working on making the llvm-dwarfdump output more flexible, e.g. adding verbose, brief mode etc.
This commit introduces a structure that holds all the flags that control the pretty printing of dwarf output.

Diff Detail

Repository
rL LLVM

Event Timeline

sgravani created this revision.May 31 2017, 5:15 PM
dblaikie accepted this revision.May 31 2017, 5:26 PM
dblaikie added inline comments.
include/llvm/DebugInfo/DIContext.h
155 ↗(On Diff #100945)

Use non-static data member initializers rather than a user-defined ctor.

tools/llvm-dwarfdump/llvm-dwarfdump.cpp
99 ↗(On Diff #100945)

Doubt the comment needs to change - the code seems pretty self explanatory.

tools/llvm-objdump/MachODump.cpp
1273 ↗(On Diff #100945)

similarly here (code seems self explanatory)

Though, equally, in this and the toher case, you could use: '{DwarfDumpType, true /* DumpEH */, false /* SummarizeTypes */}" if you like

tools/llvm-objdump/llvm-objdump.cpp
2066 ↗(On Diff #100945)

similarly here

This revision is now accepted and ready to land.May 31 2017, 5:26 PM
sgravani updated this revision to Diff 101051.Jun 1 2017, 10:59 AM
  1. Replace user-defined ctor with non-static member initializers for struct DIDumpOptions.
  2. Revert comments for dumping the complete DWARF structure to their initial form.
aprantl edited edge metadata.Jun 1 2017, 11:01 AM

Thanks. I can commit this for you.

This revision was automatically updated to reflect the committed changes.