This is an archive of the discontinued LLVM Phabricator instance.

Differential D33611

[asan] Enable back halt_on_error-torture.cc disabled on PowerPC.
ClosedPublic

Authored by alekseyshl on May 26 2017, 4:03 PM.

Details

Reviewers
eugenis
Commits
rGf8f8f49a24b8: [asan] Enable back halt_on_error-torture.cc disabled on PowerPC.
rCRT304045: [asan] Enable back halt_on_error-torture.cc disabled on PowerPC.
rL304045: [asan] Enable back halt_on_error-torture.cc disabled on PowerPC.
Summary

D33521 addressed a memory ordering issue in BlockingMutex, which seems
to be the cause of a flakiness of a few ASan tests on PowerPC.

Diff Detail

Event Timeline

alekseyshl created this revision.May 26 2017, 4:03 PM
Herald added subscribers: nemanjai, kubamracek. · View Herald TranscriptMay 26 2017, 4:03 PM
eugenis accepted this revision.May 26 2017, 4:06 PM
This revision is now accepted and ready to land.May 26 2017, 4:06 PM
Closed by commit rL304045: [asan] Enable back halt_on_error-torture.cc disabled on PowerPC. (authored by alekseyshl). · Explain WhyMay 26 2017, 4:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
asan/
TestCases/
Posix/
4 lines

Diff 100489

test/asan/TestCases/Posix/halt_on_error-torture.cc

Show All 12 Lines
// RUN: %env_asan_opts=halt_on_error=false:suppress_equal_pcs=false %run %t 10 20 >>10.txt 2>&1 || true // RUN: %env_asan_opts=halt_on_error=false:suppress_equal_pcs=false %run %t 10 20 >>10.txt 2>&1 || true
// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 10.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 10.txt // RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 10.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 10.txt
// //
// Collisions are unlikely but still possible so we need the ||. // Collisions are unlikely but still possible so we need the ||.
// RUN: rm -f 20.txt // RUN: rm -f 20.txt
// RUN: %env_asan_opts=halt_on_error=false %run %t 10 20 >>20.txt 2>&1 || true // RUN: %env_asan_opts=halt_on_error=false %run %t 10 20 >>20.txt 2>&1 || true
// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 20.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 20.txt // RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 20.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 20.txt
// UNSUPPORTED: powerpc64-unknown-linux-gnu
// FIXME: This test regularly fails on powerpc64 BE. Re-enable the test once
// the problem(s) have been fixed.
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <pthread.h> #include <pthread.h>
#include <time.h> #include <time.h>
#include <sanitizer/asan_interface.h> #include <sanitizer/asan_interface.h>
size_t nthreads = 10; size_t nthreads = 10;
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines