This is an archive of the discontinued LLVM Phabricator instance.

Differential D33582

[lib/LTO] Don't reinvent the code for switching linkage
ClosedPublic

Authored by davide on May 25 2017, 7:43 PM.

Details

Reviewers
pcc
Commits
rGd4db116af834: [lib/LTO] Don't reinvent the code for switching linkage.
rL304040: [lib/LTO] Don't reinvent the code for switching linkage.

Diff Detail

Event Timeline

davide created this revision.May 25 2017, 7:43 PM
Herald added subscribers: inglorion, mehdi_amini. · View Herald TranscriptMay 25 2017, 7:43 PM
pcc accepted this revision.May 25 2017, 7:55 PM

LGTM

This revision is now accepted and ready to land.May 25 2017, 7:55 PM
Closed by commit rL304040: [lib/LTO] Don't reinvent the code for switching linkage. (authored by davide). · Explain WhyMay 26 2017, 2:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
LTO/
14 lines

Diff 100356

lib/LTO/LTO.cpp

Show First 20 Lines • Show All 492 Lines • ▼ Show 20 Lines
ModuleSymbolTable::Symbol Msym = *MsymI++; ModuleSymbolTable::Symbol Msym = *MsymI++;
Skip(); Skip();
if (GlobalValue *GV = Msym.dyn_cast<GlobalValue *>()) { if (GlobalValue *GV = Msym.dyn_cast<GlobalValue *>()) {
if (Res.Prevailing) { if (Res.Prevailing) {
if (Sym.isUndefined()) if (Sym.isUndefined())
continue; continue;
Keep.push_back(GV); Keep.push_back(GV);
switch (GV->getLinkage()) { GlobalValue::LinkageTypes OriginalLinkage = GV->getLinkage();
default: if (GlobalValue::isLinkOnceLinkage(OriginalLinkage))
break; GV->setLinkage(GlobalValue::getWeakLinkage(
case GlobalValue::LinkOnceAnyLinkage: GlobalValue::isLinkOnceODRLinkage(OriginalLinkage)));
GV->setLinkage(GlobalValue::WeakAnyLinkage);
break;
case GlobalValue::LinkOnceODRLinkage:
GV->setLinkage(GlobalValue::WeakODRLinkage);
break;
}
} else if (isa<GlobalObject>(GV) && } else if (isa<GlobalObject>(GV) &&
(GV->hasLinkOnceODRLinkage() || GV->hasWeakODRLinkage() || (GV->hasLinkOnceODRLinkage() || GV->hasWeakODRLinkage() ||
GV->hasAvailableExternallyLinkage()) && GV->hasAvailableExternallyLinkage()) &&
!AliasedGlobals.count(cast<GlobalObject>(GV))) { !AliasedGlobals.count(cast<GlobalObject>(GV))) {
// Either of the above three types of linkage indicates that the // Either of the above three types of linkage indicates that the
// chosen prevailing symbol will have the same semantics as this copy of // chosen prevailing symbol will have the same semantics as this copy of
// the symbol, so we can link it with available_externally linkage. We // the symbol, so we can link it with available_externally linkage. We
// only need to do this if the symbol is undefined. // only need to do this if the symbol is undefined.
▲ Show 20 Lines • Show All 492 Lines • Show Last 20 Lines