This is an archive of the discontinued LLVM Phabricator instance.

ELF: The later of --build-id and --build-id= wins.
ClosedPublic

Authored by pcc on May 23 2017, 2:08 PM.

Details

Summary

If the compiler driver passes --build-id and the user uses -Wl to
pass --build-id= then the user's flag should take precedence.

Event Timeline

pcc created this revision.May 23 2017, 2:08 PM
pcc added inline comments.May 23 2017, 2:09 PM
lld/ELF/Driver.cpp
576

Sorry, need a null check here. I'll upload a new patch.

pcc updated this revision to Diff 99988.May 23 2017, 2:12 PM
  • Add null check
ruiu accepted this revision.May 23 2017, 2:14 PM

LGTM

This revision is now accepted and ready to land.May 23 2017, 2:14 PM
This revision was automatically updated to reflect the committed changes.