Page MenuHomePhabricator

[AMDGPU] Do not require opencl triple environment for OpenCL
ClosedPublic

Authored by yaxunl on May 23 2017, 8:44 AM.

Details

Summary

A recent change requires opencl triple environment for compiling OpenCL
program, which causes regressions in libclc.

This patch fixes that. Instead of deducing language based on triple
environment, it checks LangOptions.

Diff Detail

Repository
rL LLVM

Event Timeline

yaxunl created this revision.May 23 2017, 8:44 AM
tstellar accepted this revision.May 23 2017, 8:49 AM

Thanks!

test/CodeGenOpenCL/amdgpu-alignment.cl
2 ↗(On Diff #99921)

You might want to have two run lines for each test, one with no environment and one with the -opencl environment to make sure that doesn't break in the future. Otherwise, LGTM.

This revision is now accepted and ready to land.May 23 2017, 8:49 AM
yaxunl added inline comments.May 23 2017, 8:51 AM
test/CodeGenOpenCL/amdgpu-alignment.cl
2 ↗(On Diff #99921)

I will add them when committing. Thanks.

This revision was automatically updated to reflect the committed changes.