This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Split clangd into library+executable (mainly for unit tests).
ClosedPublic

Authored by ilya-biryukov on May 22 2017, 1:44 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

ilya-biryukov created this revision.May 22 2017, 1:44 AM
ilya-biryukov added a project: Restricted Project.May 22 2017, 2:20 AM
krasimir added inline comments.May 22 2017, 4:57 AM
clangd/tool/ClangdMain.cpp
11 ↗(On Diff #99723)

I'd suggest to not have parent directory includes, but add them to the cmake file as in other extra tools, like in:
https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-query/tool/CMakeLists.txt

Got rid of relative includes from parent dir in ClangdMain.cpp. (Addressed krasimir's comments)

ilya-biryukov marked an inline comment as done.May 22 2017, 9:10 AM
ilya-biryukov added inline comments.
clangd/tool/ClangdMain.cpp
11 ↗(On Diff #99723)

Done. I've actually followed a pattern of CMakeLists.txt from tool-extra, albeit a different one :-)
https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-tidy/tool/ClangTidyMain.cpp

bkramer accepted this revision.May 22 2017, 9:27 AM

looks good to me

This revision is now accepted and ready to land.May 22 2017, 9:27 AM
This revision was automatically updated to reflect the committed changes.