This is an archive of the discontinued LLVM Phabricator instance.

[lib/Object] - Minor API update for llvm::Decompressor.
ClosedPublic

Authored by grimar on May 15 2017, 7:44 AM.

Details

Summary

I revisited Decompressor API (issue with it was triggered during D32865 review)
and found it is probably provides more then we really need.

Issue was about next method's signature:

Error decompress(SmallString<32> &Out);

It is too strict. At first I wanted to change it to decompress(SmallVectorImpl<char> &Out),
but then found it is still not flexible because sticks to SmallVector.

During reviews was suggested to use templating to simplify code. Patch do that.

Diff Detail

Event Timeline

grimar created this revision.May 15 2017, 7:44 AM
grimar edited the summary of this revision. (Show Details)
grimar added subscribers: grimar, evgeny777.
grimar updated this revision to Diff 99282.May 17 2017, 6:18 AM
grimar retitled this revision from [lib/Object] - Minor API update for llvm::Decompressor (simplify). to [lib/Object] - Minor API update for llvm::Decompressor..
grimar edited the summary of this revision. (Show Details)
  • Addressed review comment.
grimar updated this revision to Diff 99284.May 17 2017, 6:22 AM
  • Fix comment.
This revision was automatically updated to reflect the committed changes.