Page MenuHomePhabricator

[PowerPC] Fix test case sem_init_glibc.cc for powerpc64be
AcceptedPublic

Authored by seurer on May 12 2017, 2:07 PM.

Details

Summary

On powerpc64be semval_t must be 64 bits even with "old" versions of glibc. This was discovered on a new install of Redhat 7.3 which unfortunately still comes with glibc 2.17 installed.

Diff Detail

Event Timeline

seurer created this revision.May 12 2017, 2:07 PM
inouehrs added inline comments.
test/sanitizer_common/TestCases/Linux/sem_init_glibc.cc
12

Is there any difference between __PPC64__ and defined(__powerpc64__) used below (and also in altivec.h etc)?

seurer added inline comments.May 16 2017, 9:16 AM
test/sanitizer_common/TestCases/Linux/sem_init_glibc.cc
12

Both PPC64 and powerpc64 are listed in the power ISA document and are equivalent.

echristo accepted this revision.May 17 2017, 3:16 PM
This revision is now accepted and ready to land.May 17 2017, 3:16 PM