This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] TwineLocalCheck: add param # checking
ClosedPublic

Authored by yawanng on May 11 2017, 9:32 AM.

Reviewers

chh
bkramer

Commits

Summary

The statement getArg tries to get the first one without checking, which may cause segmentation fault.

yawanng added a subscriber: cfe-commits.

Add more tests.

LGTM. Leave approval to bkramer.

looks good, thanks!

This revision is now accepted and ready to land.May 12 2017, 1:19 AM

wangxindsb removed a subscriber: wangxindsb.

Path

Size

clang-tidy/

llvm/

5 lines

Show All 29 Lines	auto Diag = diag(VD->getLocation(),
"twine variables are prone to use-after-free bugs");		"twine variables are prone to use-after-free bugs");

// If this VarDecl has an initializer try to fix it.		// If this VarDecl has an initializer try to fix it.
if (VD->hasInit()) {		if (VD->hasInit()) {
// Peel away implicit constructors and casts so we can see the actual type		// Peel away implicit constructors and casts so we can see the actual type
// of the initializer.		// of the initializer.
const Expr *C = VD->getInit()->IgnoreImplicit();		const Expr *C = VD->getInit()->IgnoreImplicit();

while (isa<CXXConstructExpr>(C))		while (isa<CXXConstructExpr>(C)) {
		if (cast<CXXConstructExpr>(C)->getNumArgs() == 0)
		break;
C = cast<CXXConstructExpr>(C)->getArg(0)->IgnoreParenImpCasts();		C = cast<CXXConstructExpr>(C)->getArg(0)->IgnoreParenImpCasts();
		}

SourceRange TypeRange =		SourceRange TypeRange =
VD->getTypeSourceInfo()->getTypeLoc().getSourceRange();		VD->getTypeSourceInfo()->getTypeLoc().getSourceRange();

// A real Twine, turn it into a std::string.		// A real Twine, turn it into a std::string.
if (VD->getType()->getCanonicalTypeUnqualified() ==		if (VD->getType()->getCanonicalTypeUnqualified() ==
C->getType()->getCanonicalTypeUnqualified()) {		C->getType()->getCanonicalTypeUnqualified()) {
SourceLocation EndLoc = Lexer::getLocForEndOfToken(		SourceLocation EndLoc = Lexer::getLocForEndOfToken(
Show All 16 Lines