This is an archive of the discontinued LLVM Phabricator instance.

[GlobalISel][X86] G_ICMP support.
ClosedPublic

Authored by igorb on May 9 2017, 4:34 AM.

Details

Summary

support G_ICMP for scalar types i8/i16/i64.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb created this revision.May 9 2017, 4:34 AM
guyblank added inline comments.May 10 2017, 1:43 AM
lib/Target/X86/X86FastISel.cpp
183 ↗(On Diff #98267)

perhaps commit this separately as an NFC?

lib/Target/X86/X86InstrInfo.h
67 ↗(On Diff #98267)

wheter -> whether

lib/Target/X86/X86InstructionSelector.cpp
627 ↗(On Diff #98267)

indentation

628 ↗(On Diff #98267)

getSETFromCond asserts this already

lib/Target/X86/X86LegalizerInfo.cpp
93 ↗(On Diff #98267)

unrelated to this patch, but can we have the common legalization info for 32/64 bit in one function?

igorb updated this revision to Diff 98447.May 10 2017, 7:04 AM
igorb marked 4 inline comments as done.
  • Fixes according to the review comments.
lib/Target/X86/X86LegalizerInfo.cpp
93 ↗(On Diff #98267)

Yes, I am going to merge it in a few patches.

This revision is now accepted and ready to land.May 10 2017, 9:51 PM
This revision was automatically updated to reflect the committed changes.