This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Fix validation of start function
ClosedPublic

Authored by sbc100 on May 8 2017, 5:04 PM.

Details

Summary

The check for valid start function was inverted. Added a new
test in test/Object to check this case and fixed the existing
tests in for ObjectYAML.

Event Timeline

sbc100 created this revision.May 8 2017, 5:04 PM
sbc100 updated this revision to Diff 98236.May 8 2017, 5:06 PM

fix condition

dschuff accepted this revision.May 8 2017, 6:28 PM

I guess lib/object isn't really the place to be validating things like the signature of the start function...

This revision is now accepted and ready to land.May 8 2017, 6:28 PM
This revision was automatically updated to reflect the committed changes.