Page MenuHomePhabricator

[IR] Abstract away ArgNo+1 attribute indexing as much as possible
ClosedPublic

Authored by rnk on May 3 2017, 9:26 AM.

Details

Summary

Do three things to help with that:

  • Add AttributeList::FirstArgIndex, which is an enumerator currently set to 1. It allows us to change the indexing scheme with fewer changes.
  • Add addParamAttr/removeParamAttr. This just shortens addAttribute call sites that would otherwise need to spell out FirstArgIndex.
  • Remove some attribute-specific getters and setters from Function that take attribute list indices. Most of these were only used from BuildLibCalls, and doesNotAlias was only used to test or set if the return value is malloc-like.

I'm happy to split the patch, but I think they are probably easier to
review when taken together.

This patch should be NFC, but it sets the stage to change the indexing
scheme to this, which is more convenient when indexing into an array:

0: func attrs
1: retattrs
2...: arg attrs

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.May 3 2017, 9:26 AM
pete accepted this revision.May 3 2017, 11:06 AM

This is a great improvement over what we had. LGTM.

This revision is now accepted and ready to land.May 3 2017, 11:06 AM
This revision was automatically updated to reflect the committed changes.