This is an archive of the discontinued LLVM Phabricator instance.

[StackMaps] Increase the size of the "location size" field
ClosedPublic

Authored by sanjoy on Apr 27 2017, 5:54 PM.

Details

Summary

In some cases LLVM (especially the SLP vectorizer) will create vectors
that are 256 bytes (or larger). Given that this is intentional[0] is
likely to get more common, this patch updates the StackMap binary
format to deal with the spill locations for said vectors.

This change also bumps the stack map version from 2 to 3.

[0]: https://reviews.llvm.org/D32533#738350

Diff Detail

Repository
rL LLVM

Event Timeline

sanjoy created this revision.Apr 27 2017, 5:54 PM
reames accepted this revision.Apr 27 2017, 6:42 PM

LGTM

docs/StackMaps.rst
342 ↗(On Diff #97031)

It's really unfortunate that we had to grow the size so much here, but given this is intended to be immediately parsed and thrown away, I guess it's not too much of a problem.

This revision is now accepted and ready to land.Apr 27 2017, 6:42 PM
skatkov accepted this revision.Apr 27 2017, 6:59 PM
This revision was automatically updated to reflect the committed changes.