- User Since
- Apr 20 2016, 2:02 PM (240 w, 2 d)
Jan 24 2017
I'll note that the requirement that the # call args and flags are i32s conflicts with the rest of the documentation, namely, that the flags argument is 64 bits wide.
Sep 14 2016
I don't have commit access, so if you could merge this patch for me that would be great.
Sep 12 2016
Sep 10 2016
When the op code is a patchpoint, isn't a call still emitted? I think maybe the total number of bytes returned for patchpoints should include the bytes for the call.
Sep 9 2016
Okay, here's a version with the stackmap version bumped to 2.
Aug 22 2016
This revision includes the changes requested in the inline comments.
(added replies to inline comments ahead of adding a new revision)
@ributzka The bug that is fixed by this patch helps all users of stackmaps (gc.statepoint and patchpoints), because you couldn't associate callsites with their functions. I think we should at least merge this fix in so that the current stackmap format is actually usable.
Updated per sanjoy's inline feedback.
Aug 21 2016
this looks like the kind of thing that would involve bumping the stackmap version from 1 to 2.
I updated the original patch so that the record counts are 8 bytes wide instead of 4 bytes wide to fix an alignment issue in the StackMapParser.