Page MenuHomePhabricator

kavon (Kavon Farvardin)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2016, 2:02 PM (240 w, 2 d)

Recent Activity

Jan 24 2017

kavon added a comment to D29112: NFC: Fix typo in Statepoint documentation.

I'll note that the requirement that the # call args and flags are i32s conflicts with the rest of the documentation, namely, that the flags argument is 64 bits wide.

Jan 24 2017, 7:41 PM · Restricted Project
kavon created D29112: NFC: Fix typo in Statepoint documentation.
Jan 24 2017, 7:34 PM · Restricted Project

Sep 14 2016

kavon added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

I don't have commit access, so if you could merge this patch for me that would be great.

Sep 14 2016, 5:59 AM

Sep 12 2016

kavon accepted D24073: [AArch64] Support stackmap/patchpoint in getInstSizeInBytes.

When the op code is a patchpoint, isn't a call still emitted? I think maybe the total number of bytes returned for patchpoints should include the bytes for the call.

From my reading of AArch64AsmPrinter::LowerPATCHPOINT, it looks like the number of bytes requested by the patchpoint has to include the bytes for the call - i.e. if the call is generated, its size is subtracted from the number of bytes requested, and only the remaining number of nops are added.

Sep 12 2016, 7:00 AM

Sep 10 2016

kavon added a comment to D24073: [AArch64] Support stackmap/patchpoint in getInstSizeInBytes.

When the op code is a patchpoint, isn't a call still emitted? I think maybe the total number of bytes returned for patchpoints should include the bytes for the call.

Sep 10 2016, 1:58 PM

Sep 9 2016

kavon updated the diff for D23487: [Stackmap] Added callsite counts to emitted function information..

Okay, here's a version with the stackmap version bumped to 2.

Sep 9 2016, 7:54 PM

Aug 22 2016

kavon updated the diff for D23487: [Stackmap] Added callsite counts to emitted function information..

This revision includes the changes requested in the inline comments.

Aug 22 2016, 8:46 PM
kavon added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

(added replies to inline comments ahead of adding a new revision)

Aug 22 2016, 8:41 PM
kavon added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

Hi @kavon,

this looks like the kind of thing that would involve bumping the stackmap version from 1 to 2.

@sanjoy and others: if this is decided, then the patch will have to change quite a lot, so please let me know!

Sorry, I forgot about this bit in the last review. I think the version number needs to change. While I agree that this can be seen as "bugfix" kind of change, in practice changing the format without a version bump will silently break backends.

Aug 22 2016, 12:47 PM
kavon added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

@ributzka The bug that is fixed by this patch helps all users of stackmaps (gc.statepoint and patchpoints), because you couldn't associate callsites with their functions. I think we should at least merge this fix in so that the current stackmap format is actually usable.

Aug 22 2016, 12:40 PM
kavon updated the diff for D23487: [Stackmap] Added callsite counts to emitted function information..

Updated per sanjoy's inline feedback.

Aug 22 2016, 12:20 PM

Aug 21 2016

kavon added a comment to D23487: [Stackmap] Added callsite counts to emitted function information..

this looks like the kind of thing that would involve bumping the stackmap version from 1 to 2.

Aug 21 2016, 9:35 PM
kavon updated the diff for D23487: [Stackmap] Added callsite counts to emitted function information..

I updated the original patch so that the record counts are 8 bytes wide instead of 4 bytes wide to fix an alignment issue in the StackMapParser.

Aug 21 2016, 9:14 PM

Aug 13 2016

kavon retitled D23487: [Stackmap] Added callsite counts to emitted function information. from to [Stackmap] Added callsite counts to emitted function information..
Aug 13 2016, 4:37 PM