clang-format: [JS/Java] ignore Objective-C constructs in JS & Java.

[mprobst]

Summary

Java and JavaScript support annotations and decorators, respectively, that use a leading "@" token. clang-format currently detects this as an Objective-C construct and applies special formatting, for example no whitespace around "=" operators. This change disables the distinction for Java and JavaScript, which leads to normal formatting of single line annotated and initialized properties.

Before:

class X {
  @foo() bar=false;
}

After:

class X {
  @foo() bar = false;
}

[djasper]

Looks good.

cfe/trunk/lib/Format/TokenAnnotator.cpp

if (Current.is(Keywords.kw_instanceof)) {
             if (FormatToken *BeforeParen = Current.MatchingParen->Previous)
               if (BeforeParen->is(tok::identifier) &&
                   BeforeParen->TokenText == BeforeParen->TokenText.upper() &&
                   (!BeforeParen->Previous ||
                    BeforeParen->Previous->ClosesTemplateDeclaration))
                 Current.Type = TT_FunctionAnnotationRParen;
           }
         }
-    } else if (Current.is(tok::at) && Current.Next) {
+    } else if (Current.is(tok::at) && Current.Next &&
+               Style.Language != FormatStyle::LK_JavaScript &&
+               Style.Language != FormatStyle::LK_Java) {
+      // In Java & JavaScript, "@..." is a decorator or annotation. In ObjC, it
+      // marks declarations and properties that need special formatting.
       switch (Current.Next->Tok.getObjCKeywordID()) {
       case tok::objc_interface:
       case tok::objc_implementation:
       case tok::objc_protocol:
         Current.Type = TT_ObjCDecl;
         break;
       case tok::objc_property:
         Current.Type = TT_ObjCProperty;

cfe/trunk/unittests/Format/FormatTestJS.cpp

verifyFormat("class C {\n"
                "    return 'y';\n"
                "  }\n"
                "}");
   verifyFormat("class C {\n"
                "  private x(@A x: string) {}\n"
                "}");
   verifyFormat("class X {}\n"
                "class Y {}");
+  verifyFormat("class X {\n"
+               "  @property() private isReply = false;\n"
+               "}\n");
 }
 
 TEST_F(FormatTestJS, TypeAliases) {
   verifyFormat("type X = number;\n"
                "class C {}");
   verifyFormat("type X<Y> = Z<Y>;");
   verifyFormat("type X = {\n"
                "  y: number\n"