This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add missing mayLoad/mayStore attributes to some X86 instructions (Continue)
ClosedPublic

Authored by aymanmus on Apr 20 2017, 4:55 AM.

Diff Detail

Event Timeline

aymanmus created this revision.Apr 20 2017, 4:55 AM
RKSimon added a subscriber: RKSimon.

Doesn't this need to be done for ArithBinOp_RFF and ArithBinOp_F as well?

@RKSimon i guess there are much more records missing this attributes, but this patch is only to enable my upcoming patch of auto generating the memory folding tables to not crash.
We can define a new task of "making sure mayLoad/mayStore attributes are correctly set for all instructions". But until this moment, only this is needed.

RKSimon accepted this revision.Apr 26 2017, 2:45 AM

@RKSimon i guess there are much more records missing this attributes, but this patch is only to enable my upcoming patch of auto generating the memory folding tables to not crash.
We can define a new task of "making sure mayLoad/mayStore attributes are correctly set for all instructions". But until this moment, only this is needed.

OK - LGTM

This revision is now accepted and ready to land.Apr 26 2017, 2:45 AM
This revision was automatically updated to reflect the committed changes.