[X86] Add missing mayLoad/mayStore attributes to some X86 instructions (Continue)

[aymanmus]

Summary

Complete the patch committed in rL300190.

[RKSimon]

Doesn't this need to be done for ArithBinOp_RFF and ArithBinOp_F as well?

[aymanmus]

@RKSimon i guess there are much more records missing this attributes, but this patch is only to enable my upcoming patch of auto generating the memory folding tables to not crash.
We can define a new task of "making sure mayLoad/mayStore attributes are correctly set for all instructions". But until this moment, only this is needed.

[RKSimon]

In D32287#737719, @aymanmus wrote:

@RKSimon i guess there are much more records missing this attributes, but this patch is only to enable my upcoming patch of auto generating the memory folding tables to not crash.
We can define a new task of "making sure mayLoad/mayStore attributes are correctly set for all instructions". But until this moment, only this is needed.

OK - LGTM

llvm/trunk/lib/Target/X86/X86InstrArithmetic.td

let Constraints = "$src1 = $dst" in {
         def NAME#64ri8 : BinOpRI8_RF<0x82, mnemonic, Xi64, opnodeflag, RegMRM>;
 
         def NAME#16ri  : BinOpRI_RF<0x80, mnemonic, Xi16, opnodeflag, RegMRM>;
         def NAME#32ri  : BinOpRI_RF<0x80, mnemonic, Xi32, opnodeflag, RegMRM>;
         def NAME#64ri32: BinOpRI_RF<0x80, mnemonic, Xi64, opnodeflag, RegMRM>;
       }
     } // Constraints = "$src1 = $dst"
 
+    let mayLoad = 1, mayStore = 1 in {
       def NAME#8mr    : BinOpMR_RMW<BaseOpc, mnemonic, Xi8 , opnode>;
       def NAME#16mr   : BinOpMR_RMW<BaseOpc, mnemonic, Xi16, opnode>;
       def NAME#32mr   : BinOpMR_RMW<BaseOpc, mnemonic, Xi32, opnode>;
       def NAME#64mr   : BinOpMR_RMW<BaseOpc, mnemonic, Xi64, opnode>;
+    }
 
     // NOTE: These are order specific, we want the mi8 forms to be listed
     // first so that they are slightly preferred to the mi forms.
     def NAME#16mi8  : BinOpMI8_RMW<mnemonic, Xi16, opnode, MemMRM>;
     def NAME#32mi8  : BinOpMI8_RMW<mnemonic, Xi32, opnode, MemMRM>;
     def NAME#64mi8  : BinOpMI8_RMW<mnemonic, Xi64, opnode, MemMRM>;
 
     def NAME#8mi    : BinOpMI_RMW<0x80, mnemonic, Xi8 , opnode, MemMRM>;