[msan] Fix msan_test broken after r299884.

[vitalybuka]

Summary

Bind to ANY as some machines may have IPv6 support but without IPv6 on loopback
interface.

[eugenis]

LGTM

[hfinkel]

LGTM, let's try it. It would be good to commit the vector fix separately in case we need to revert the interface change we shouldn't lose the bug fix too.

[vitalybuka]

Move vector fix into separate patch.

[vitalybuka]

In D31998#725569, @hfinkel wrote:

LGTM, let's try it. It would be good to commit the vector fix separately in case we need to revert the interface change we shouldn't lose the bug fix too.

Done

lib/msan/tests/msan_test.cc

 
 class SocketAddr4 : public SocketAddr {
  public:
   SocketAddr4() { EXPECT_POISONED(sai_); }
   explicit SocketAddr4(uint16_t port) {
     memset(&sai_, 0, sizeof(sai_));
     sai_.sin_family = AF_INET;
     sai_.sin_port = port;
-    sai_.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
+    sai_.sin_addr.s_addr = htonl(INADDR_ANY);
   }
 
   sockaddr *ptr() override { return reinterpret_cast<sockaddr *>(&sai_); }
 
   size_t size() const override { return sizeof(sai_); }
 
  private:
   sockaddr_in sai_;
 };
 
 class SocketAddr6 : public SocketAddr {
  public:
   SocketAddr6() { EXPECT_POISONED(sai_); }
   explicit SocketAddr6(uint16_t port) {
     memset(&sai_, 0, sizeof(sai_));
     sai_.sin6_family = AF_INET6;
     sai_.sin6_port = port;
-    sai_.sin6_addr = in6addr_loopback;
+    sai_.sin6_addr = in6addr_any;
   }
 
   sockaddr *ptr() override { return reinterpret_cast<sockaddr *>(&sai_); }
 
   size_t size() const override { return sizeof(sai_); }
 
  private:
   sockaddr_in6 sai_;
public:
   int CreateSocket(int socket_type) const {
     return socket(GetParam(), socket_type, 0);
   }
 };
 
 std::vector<int> GetAvailableIpSocketFamilies() {
   std::vector<int> result;
 
-  for (int i : std::vector<int>(AF_INET, AF_INET6)) {
+  for (int i : {AF_INET, AF_INET6}) {
     int s = socket(i, SOCK_STREAM, 0);
     if (s > 0) {
       result.push_back(i);
       close(s);
     }
   }
 
   return result;