This is an archive of the discontinued LLVM Phabricator instance.

Differential D31376

[sanitizers] Avoid using -fomit-frame-pointer on Darwin
ClosedPublic

Authored by kubamracek on Mar 26 2017, 2:28 PM.

Details

Reviewers
kcc
filcab
dvyukov
Commits
rG90caf899eb86: [sanitizers] Avoid using -fomit-frame-pointer on Darwin
rCRT298859: [sanitizers] Avoid using -fomit-frame-pointer on Darwin
rL298859: [sanitizers] Avoid using -fomit-frame-pointer on Darwin
Summary

On Darwin, we're having multiple issues with using -fomit-frame-pointer in the AddressSanitizer and ThreadSanitizer runtimes, so we're actually not using -fomit-frame-pointer in the our builds of the sanitizer dylibs. This patch just pushes our internal change upstream.

The issues are usually with debuggers, profilers and other tools that unwind the stack (crash reporter), which are often simply not able to get a stack trace. And crashlogs that don't contain a stack trace are a huge problem.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek created this revision.Mar 26 2017, 2:28 PM
Herald added a subscriber: mgorny. · View Herald TranscriptMar 26 2017, 2:28 PM
dvyukov accepted this revision.Mar 27 2017, 6:56 AM
This revision is now accepted and ready to land.Mar 27 2017, 6:56 AM
filcab accepted this revision.Mar 27 2017, 8:01 AM

Hopefully this will allow us to turn on -Werror on the sanitizers when building them for iOS/OS X (ARM targets don't support -fomit-frame-pointer).

Closed by commit rL298859: [sanitizers] Avoid using -fomit-frame-pointer on Darwin (authored by kuba.brecka). · Explain WhyMar 27 2017, 10:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
2 lines

Diff 93152

compiler-rt/trunk/CMakeLists.txt

Show First 20 Lines • Show All 118 Lines • ▼ Show 20 Lines
endif() endif()
# Provide some common commmandline flags for Sanitizer runtimes. # Provide some common commmandline flags for Sanitizer runtimes.
if(NOT WIN32) if(NOT WIN32)
append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC SANITIZER_COMMON_CFLAGS)
endif() endif()
append_list_if(COMPILER_RT_HAS_FNO_BUILTIN_FLAG -fno-builtin SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FNO_BUILTIN_FLAG -fno-builtin SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_FNO_EXCEPTIONS_FLAG -fno-exceptions SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FNO_EXCEPTIONS_FLAG -fno-exceptions SANITIZER_COMMON_CFLAGS)
if(NOT COMPILER_RT_DEBUG) if(NOT COMPILER_RT_DEBUG AND NOT APPLE)
append_list_if(COMPILER_RT_HAS_FOMIT_FRAME_POINTER_FLAG -fomit-frame-pointer SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FOMIT_FRAME_POINTER_FLAG -fomit-frame-pointer SANITIZER_COMMON_CFLAGS)
endif() endif()
append_list_if(COMPILER_RT_HAS_FUNWIND_TABLES_FLAG -funwind-tables SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FUNWIND_TABLES_FLAG -funwind-tables SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_FNO_STACK_PROTECTOR_FLAG -fno-stack-protector SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FNO_STACK_PROTECTOR_FLAG -fno-stack-protector SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_FNO_SANITIZE_SAFE_STACK_FLAG -fno-sanitize=safe-stack SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FNO_SANITIZE_SAFE_STACK_FLAG -fno-sanitize=safe-stack SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_FVISIBILITY_HIDDEN_FLAG -fvisibility=hidden SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FVISIBILITY_HIDDEN_FLAG -fvisibility=hidden SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_FVISIBILITY_INLINES_HIDDEN_FLAG -fvisibility-inlines-hidden SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FVISIBILITY_INLINES_HIDDEN_FLAG -fvisibility-inlines-hidden SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_FNO_LTO_FLAG -fno-lto SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FNO_LTO_FLAG -fno-lto SANITIZER_COMMON_CFLAGS)
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines