This is an archive of the discontinued LLVM Phabricator instance.

Remove stale and unused (MC)TargetOptions comparators.
ClosedPublic

Authored by tejohnson on Mar 23 2017, 1:11 PM.

Details

Summary

I discovered accidentally that the operator== for TargetOptions
is stale - it is missing many fields that have been added over
the recent years. It isn't used, so remove it. Ditto for the
comparator in MCTargetOptions, which doesn't seem stale yet but is
unused.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.Mar 23 2017, 1:11 PM
echristo edited edge metadata.Mar 23 2017, 6:50 PM

Should we delete the function so that no one tries to use it?

Should we delete the function so that no one tries to use it?

Do you mean mark it explicitly deleted? Is that necessary since it won't create one of these by default? I tried calling them and there are compiler errors.

echristo accepted this revision.Mar 23 2017, 10:32 PM

Oh, sure. :)

Thanks!

-eric

This revision is now accepted and ready to land.Mar 23 2017, 10:32 PM
This revision was automatically updated to reflect the committed changes.