Thanks to Vitaly Buka for helping catch this.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/Target/ARM/ARMInstrThumb2.td | ||
---|---|---|
115 ↗ | (On Diff #92639) | Why not just use INT_MIN? |
lib/Target/ARM/ARMInstrThumb2.td | ||
---|---|---|
115 ↗ | (On Diff #92639) | getZExtValue() would have returned the unsigned value, i.e. (uint64_t)2147483648 |
llvm/trunk/lib/Target/ARM/ARMInstrThumb2.td | ||
---|---|---|
116 | I think you could simplify this pattern a bit like this: def t2_so_imm_neg : Operand<i32>, ImmLeaf<i32, [{ return Imm && ARM_AM::getT2SOImmVal(-(uint32_t)Imm) != -1; }] ... |
I think you could simplify this pattern a bit like this: