Convention in libunwind is to use !defined(FOO) not !FOO.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM minus the suggested cleanup.
| include/__libunwind_config.h | ||
|---|---|---|
| 15 ↗ | (On Diff #92140) | This should have an empty definition to avoid people depending on the value 1. |
| 20 ↗ | (On Diff #92140) | This should have an empty definition to avoid people depending on the value 1. |
| src/config.h | ||
| 35 ↗ | (On Diff #92140) | This should have an empty definition to avoid people depending on the value 1. |
| 52 ↗ | (On Diff #92140) | This should have an empty definition to avoid people depending on the value 1. |
| 56 ↗ | (On Diff #92140) | This should have an empty definition to avoid people depending on the value 1. |
| 64 ↗ | (On Diff #92140) | This should have an empty definition to avoid people depending on the value 1. |