This is an archive of the discontinued LLVM Phabricator instance.

Remove lldb streams from the Log class completely
ClosedPublic

Authored by labath on Mar 13 2017, 7:49 AM.

Details

Summary

previously we switched to llvm streams for log output, this completes
the switch for the error streams.

I also clean up the includes and remove the unused argument from
DisableAllLogChannels().

This required adding a bit of boiler plate to convert the output in the
command interpreter, but that should go away when we switch command
results to use llvm streams as well.

Event Timeline

labath created this revision.Mar 13 2017, 7:49 AM
zturner accepted this revision.Mar 14 2017, 8:01 PM

Looks great.

tools/lldb-server/LLDBServerUtilities.cpp
59–60

How about llvm::errs() << formatv("Unable to setup logging for channel \"{0}\": {1}\n", channel, error_stream.str());

This revision is now accepted and ready to land.Mar 14 2017, 8:01 PM
labath added inline comments.Mar 15 2017, 2:09 AM
tools/lldb-server/LLDBServerUtilities.cpp
59–60

good point. will do.

This revision was automatically updated to reflect the committed changes.