This is an archive of the discontinued LLVM Phabricator instance.

[Builtin][ARM] Try to address error on FreeBSD with r288777
AbandonedPublic

Authored by weimingz on Mar 11 2017, 12:21 PM.

Download Raw Diff

Details

Reviewers

dim
rengolin

Summary

It seems the only suspicious change in r288777 is the extra "#ifdef ARM_ARCH_EXT_IDIV".
The rest of the change in r288777 should not affect the "#else" part of "__ARM_ARCH_ISA_THUMB == 1"

Diff Detail

Event Timeline

weimingz created this revision.Mar 11 2017, 12:21 PM

Herald added a subscriber: aemerson. · View Herald TranscriptMar 11 2017, 12:21 PM

weimingz updated this revision to Diff 91481.Mar 11 2017, 1:20 PM

strejda mentioned this in D27309: builtins: Add ARM Thumb1 implementation for uidiv and uidivmod.Mar 11 2017, 11:51 PM

weimingz abandoned this revision.Mar 12 2017, 12:23 AM

Revision Contents

Path

Size

lib/

builtins/

arm/

udivsi3.S

12 lines

Diff 91478

lib/builtins/arm/udivsi3.S

Show First 20 Lines • Show All 246 Lines • ▼ Show 20 Lines	#endif
block(1)		block(1)
LOCAL_LABEL(div0block):		LOCAL_LABEL(div0block):
block(0)		block(0)

mov r0, r3		mov r0, r3
JMP(lr)		JMP(lr)
#endif /* __ARM_ARCH_EXT_IDIV__ */		#endif /* __ARM_ARCH_EXT_IDIV__ */

#if __ARM_ARCH_EXT_IDIV__
LOCAL_LABEL(divby0):		LOCAL_LABEL(divby0):
mov r0, #0		mov r0, #0
# ifdef __ARM_EABI__		#ifdef __ARM_EABI__
b __aeabi_idiv0		b __aeabi_idiv0
# else		#else
JMP(lr)		JMP(lr)
# endif		#endif
#endif

END_COMPILERRT_FUNCTION(__udivsi3)		END_COMPILERRT_FUNCTION(__udivsi3)

NO_EXEC_STACK_DIRECTIVE		NO_EXEC_STACK_DIRECTIVE