This is an archive of the discontinued LLVM Phabricator instance.

dotest.py: remove the ability to specify different architectures/compilers in a single invocation
ClosedPublic

Authored by labath on Mar 9 2017, 4:23 AM.

Details

Summary

This has been broken at least since the new test result framework was
added, which was over a year ago. It looks like nobody has missed it
since.

Removing this makes the gmodules handling code saner, as it already did
not know how to handle the multiple-compilers case.

My motivation for this is libc++ data formatters support on android -- I
am trying make a central way of determining whether libc++ tests can be
run, and without this, I would have to resort to similar hacks as the
gmodules code.

Event Timeline

labath created this revision.Mar 9 2017, 4:23 AM
zturner edited edge metadata.Mar 9 2017, 5:56 PM

Agree that it will be nice to see this gone. I suspect there is even more complexity than what you have here that can be removed if we aren't supporting this, but this seems like a good start.

packages/Python/lldbsuite/test/dotest.py
1204

Should you be setting CXX here?

labath added inline comments.Mar 13 2017, 5:00 AM
packages/Python/lldbsuite/test/dotest.py
1204

We don't have the CXX name here. It gets derived from the c compiler name in a pretty funny way later on.

zturner accepted this revision.Mar 14 2017, 7:52 PM
This revision is now accepted and ready to land.Mar 14 2017, 7:52 PM
This revision was automatically updated to reflect the committed changes.