Page MenuHomePhabricator

Rename PT_NOTE namespace name used in AMDGPUPTNote.h
ClosedPublic

Authored by guansong on Mar 8 2017, 10:53 AM.

Details

Summary

On Ubuntu 14.04, PT_NOTE is #defined in elf.h.

This causes potential confusion for compilation if code uses PT_NOTE from AMDGPUNote.h and also include the elf header, even you qualify the usage with AMDGPU::PT_NOTE.

Diff Detail

Repository
rL LLVM

Event Timeline

guansong created this revision.Mar 8 2017, 10:53 AM
kzhuravl accepted this revision.Mar 8 2017, 11:43 AM

LGTM with a minor nit. Will you also be able to update opencl runtime once this change gets there?

lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h
88 ↗(On Diff #91052)

Make sure the line is <80 cols.

This revision is now accepted and ready to land.Mar 8 2017, 11:43 AM
guansong updated this revision to Diff 91210.Mar 9 2017, 12:25 PM

Use ElfNote instead of AMD_PT_NOTE as suggested.

This revision was automatically updated to reflect the committed changes.