This is an archive of the discontinued LLVM Phabricator instance.

Fix test and add missing return for llvm-lto2 error case
ClosedPublic

Authored by tejohnson on Mar 3 2017, 11:49 AM.

Details

Summary

This test was missing the target triple, which was exposed by an
upcoming bugfix that requires getting the target earlier in the LTO API.

Once I fixed that, the case with the invalid character error stopped
returning 1 from llvm-lto2 and the test reported a failure. Fixed by
adding the missing return from llvm-lto2. Apparently we were failing
when we eventually tried to get the target.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.Mar 3 2017, 11:49 AM

Although the dependent patch is no longer needed, I still believe this is a correct fix.

mehdi_amini accepted this revision.Mar 7 2017, 10:23 AM

LGTM.

But are these two changes related?

This revision is now accepted and ready to land.Mar 7 2017, 10:23 AM

LGTM.

But are these two changes related?

Yes, because we were only getting an (expected) error return because of the missing target.

This revision was automatically updated to reflect the committed changes.